Skip to content

fix clippy

fix clippy #538

Triggered via pull request March 23, 2024 11:01
Status Success
Total duration 10m 15s
Artifacts

ci.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

57 warnings
empty doc comment: taiga_halo2/src/taiga_api.rs#L55
warning: empty doc comment --> taiga_halo2/src/taiga_api.rs:55:1 | 55 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs = note: `-W clippy::empty-docs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`
empty doc comment: taiga_halo2/src/taiga_api.rs#L55
warning: empty doc comment --> taiga_halo2/src/taiga_api.rs:55:1 | 55 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs = note: `-W clippy::empty-docs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`
the item `serde` is imported redundantly: taiga_halo2/src/vp_commitment.rs#L8
warning: the item `serde` is imported redundantly --> taiga_halo2/src/vp_commitment.rs:8:5 | 8 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/transparent_ptx.rs#L9
warning: the item `serde` is imported redundantly --> taiga_halo2/src/transparent_ptx.rs:9:5 | 9 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/transaction.rs#L19
warning: the item `serde` is imported redundantly --> taiga_halo2/src/transaction.rs:19:5 | 19 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `OsRng` is imported redundantly: taiga_halo2/src/taiga_api.rs#L234
warning: the item `OsRng` is imported redundantly --> taiga_halo2/src/taiga_api.rs:234:9 | 232 | taiga_api::*, | ------------ the item `OsRng` is already imported here 233 | }; 234 | use rand::rngs::OsRng; | ^^^^^^^^^^^^^^^^^
the item `serde` is imported redundantly: taiga_halo2/src/shielded_ptx.rs#L22
warning: the item `serde` is imported redundantly --> taiga_halo2/src/shielded_ptx.rs:22:5 | 22 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/resource.rs#L28
warning: the item `serde` is imported redundantly --> taiga_halo2/src/resource.rs:28:5 | 28 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/proof.rs#L12
warning: the item `serde` is imported redundantly --> taiga_halo2/src/proof.rs:12:5 | 12 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/nullifier.rs#L16
warning: the item `serde` is imported redundantly --> taiga_halo2/src/nullifier.rs:16:5 | 16 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/vp_commitment.rs#L8
warning: the item `serde` is imported redundantly --> taiga_halo2/src/vp_commitment.rs:8:5 | 8 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/merkle_tree.rs#L17
warning: the item `serde` is imported redundantly --> taiga_halo2/src/merkle_tree.rs:17:5 | 17 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/transparent_ptx.rs#L9
warning: the item `serde` is imported redundantly --> taiga_halo2/src/transparent_ptx.rs:9:5 | 9 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/delta_commitment.rs#L12
warning: the item `serde` is imported redundantly --> taiga_halo2/src/delta_commitment.rs:12:5 | 12 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/transaction.rs#L19
warning: the item `serde` is imported redundantly --> taiga_halo2/src/transaction.rs:19:5 | 19 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/shielded_ptx.rs#L22
warning: the item `serde` is imported redundantly --> taiga_halo2/src/shielded_ptx.rs:22:5 | 22 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/resource.rs#L28
warning: the item `serde` is imported redundantly --> taiga_halo2/src/resource.rs:28:5 | 28 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/proof.rs#L12
warning: the item `serde` is imported redundantly --> taiga_halo2/src/proof.rs:12:5 | 12 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/nullifier.rs#L16
warning: the item `serde` is imported redundantly --> taiga_halo2/src/nullifier.rs:16:5 | 16 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/merkle_tree.rs#L17
warning: the item `serde` is imported redundantly --> taiga_halo2/src/merkle_tree.rs:17:5 | 17 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/delta_commitment.rs#L12
warning: the item `serde` is imported redundantly --> taiga_halo2/src/delta_commitment.rs:12:5 | 12 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/compliance.rs#L22
warning: the item `serde` is imported redundantly --> taiga_halo2/src/compliance.rs:22:5 | 22 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `RngCore` is imported redundantly: taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs#L248
warning: the item `RngCore` is imported redundantly --> taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs:248:9 | 239 | use super::*; | -------- the item `RngCore` is already imported here ... 248 | use rand::RngCore; | ^^^^^^^^^^^^^
the item `OsRng` is imported redundantly: taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs#L247
warning: the item `OsRng` is imported redundantly --> taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs:247:9 | 239 | use super::*; | -------- the item `OsRng` is already imported here ... 247 | use rand::rngs::OsRng; | ^^^^^^^^^^^^^^^^^
the item `serde` is imported redundantly: taiga_halo2/src/circuit/vp_bytecode.rs#L31
warning: the item `serde` is imported redundantly --> taiga_halo2/src/circuit/vp_bytecode.rs:31:5 | 31 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/compliance.rs#L22
warning: the item `serde` is imported redundantly --> taiga_halo2/src/compliance.rs:22:5 | 22 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `TryInto` is imported redundantly: taiga_halo2/src/circuit/blake2s.rs#L19
warning: the item `TryInto` is imported redundantly --> taiga_halo2/src/circuit/blake2s.rs:19:11 | 19 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `serde` is imported redundantly: taiga_halo2/src/circuit/vp_circuit.rs#L67
warning: the item `serde` is imported redundantly --> taiga_halo2/src/circuit/vp_circuit.rs:67:5 | 67 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/circuit/vp_bytecode.rs#L31
warning: the item `serde` is imported redundantly --> taiga_halo2/src/circuit/vp_bytecode.rs:31:5 | 31 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/binding_signature.rs#L9
warning: the item `serde` is imported redundantly --> taiga_halo2/src/binding_signature.rs:9:5 | 9 | use serde; | ^^^^^ the item `serde` is already defined by prelude | = note: `#[warn(unused_imports)]` on by default
the item `TryInto` is imported redundantly: taiga_halo2/src/circuit/blake2s.rs#L19
warning: the item `TryInto` is imported redundantly --> taiga_halo2/src/circuit/blake2s.rs:19:11 | 19 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `serde` is imported redundantly: taiga_halo2/src/circuit/vp_circuit.rs#L67
warning: the item `serde` is imported redundantly --> taiga_halo2/src/circuit/vp_circuit.rs:67:5 | 67 | use serde; | ^^^^^ the item `serde` is already defined by prelude
the item `serde` is imported redundantly: taiga_halo2/src/binding_signature.rs#L9
warning: the item `serde` is imported redundantly --> taiga_halo2/src/binding_signature.rs:9:5 | 9 | use serde; | ^^^^^ the item `serde` is already defined by prelude | = note: `#[warn(unused_imports)]` on by default
Nightly lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Nightly lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy lint checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/