Port BlockSpaceAllocator to main
#976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
previously approved these changes
Jan 4, 2023
|
converted to a draft. this logic will need to change slightly, to include encrypted txs first. |
Merged
|
pls update wasm |
|
pls update wasm |
sug0
added a commit
that referenced
this pull request
Mar 7, 2023
BSA: Allocate encrypted txs first Update PrepareProposal logic Fix unit tests in PrepareProposal Update ProcessProposal logic
|
what's the status of this PR, are we just waiting for reviews? |
|
@tzemanovic yes, essentially. it has been ready for review for ages |
|
I approve but someone else should too |
tzemanovic
added a commit
that referenced
this pull request
Mar 31, 2023
* tiago/main/block-space-allocator: Check if no decrypted txs are proposed before wrapper txs Fix pos_bonds() e2e test Increase minimum epoch length in e2e tests Log the length of the excluded tx instead of its payload Fix BSA unit tests Allocate txs in block space allocator in another order: EDP Change docstrs to reflect the new order of txs in the BSA Fix test_wrapper_unknown_address() unit test Fix test_wrapper_insufficient_balance_address() unit test Fix some unit tests Rename: GetActiveValidators -> ActiveValidators PosQueries related fixes Remove need to allocate while iterating active validator sets Misc 0.14.0 rebase fixes Fix PosQueries Temporarily disable get_validator_from_tm_address() Fix ProcessProposal unit tests Fix ABCI++ build Fix import errors Fix EndBlock shim call on process_txs() Add block space allocator logic to ProcessProposal Add allocation error code to ProcessProposal Replace Vec<u8> with TxBytes Remove index-set from apps Add the block space allocator to PrepareProposal Add compiler hints Remove tx records Shim PrepareProposal response Add TODO items Add block space allocator impl Make first block heights of each epoch public Add PosQueries Add new deps Add block space allocator specs
Closed
tzemanovic
reviewed
Mar 31, 2023
tzemanovic
reviewed
Mar 31, 2023
tzemanovic
reviewed
Mar 31, 2023
tzemanovic
reviewed
Apr 4, 2023
tzemanovic
reviewed
Apr 4, 2023
tzemanovic
previously approved these changes
Apr 4, 2023
tzemanovic
approved these changes
Apr 5, 2023
tzemanovic
added a commit
that referenced
this pull request
Apr 7, 2023
* tiago/main/block-space-allocator: Improve ErrorCodes::is_recoverable() Rename active to consensus validators in PosQueries Read token balances with storage_api::token::read_balance()
tzemanovic
added a commit
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #975
Ports the following PRs to
main:ProcessProposal#950