pre-genesis wallet #870
Closed
pre-genesis wallet #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
commented
Dec 7, 2022
| @@ -165,22 +216,9 @@ impl Context { | |||
|
|
|||
| /// Get the wasm directory configured for the chain. | |||
| /// | |||
| /// Note that in "dev" build, this may be the root `wasm` dir. | |||
| /// TODO(Tomas): Note that in "dev" build, this may be the root `wasm` dir. | |||
There was a problem hiding this comment.
this is left for #685 where we're removing the "dev" build
tzemanovic
force-pushed
the
tomas/pre-genesis-wallet
branch
from
27a8824
to
97c0dd2
Compare
tzemanovic
added a commit
that referenced
this pull request
Jan 12, 2023
tzemanovic
force-pushed
the
tomas/pre-genesis-wallet
branch
from
97c0dd2
to
41bd404
Compare
tzemanovic
force-pushed
the
tomas/pre-genesis-wallet
branch
from
41bd404
to
0b3b357
Compare
|
@Fraccaman this depends on #849 which has breaking changes for genesis, so let's leave it until #685 is also ready. This PR will need to be updated for SDK |
|
replaced by #1782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #849, this PR adds
--pre-genesisargument to the wallet commands to allow to generate keys, implicit addresses and MASP keys without having a chain setup - this is a needed for #685. If no chain is setup yet (i.e. there's no.namadaor it's empty), the wallet defaults to use the pre-genesis wallet even without the--pre-genesisflag. The pre-genesis wallet is located in.namada/pre-genesis/wallet.toml.relevant commits: https://github.com/anoma/namada/pull/870/files/0f7da43aa22d12d86e917a07f80f0248a15df711..0b3b35706768a98dcc1eb844cf5d706d89f41905
closes #784