fix storage height bugs and rocksdb read from arb. height and delete's diffs #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/storage-read-height-bug
branch
from
f7fe272
to
6d9dad4
Compare
tzemanovic
added a commit
that referenced
this pull request
Oct 28, 2022
tzemanovic
force-pushed
the
tomas/storage-read-height-bug
branch
from
eaa1d30
to
109ed6e
Compare
yito88
reviewed
Nov 3, 2022
james-chf
added a commit
that referenced
this pull request
Nov 3, 2022
…/merge-0.9.0 * tomas/storage-read-height-bug: changelog: add #706 config: add `shell.storage_read_past_height_limit`, use it for queries storage: fix block heights used in read, write and delete rocksdb: fix delete_subspace_val diff write rocksdb: fix read_subspace_val_with_height test/storage: add a test for reading from arbitrary block heights # Conflicts: # apps/src/lib/node/ledger/shell/mod.rs
tzemanovic
added a commit
that referenced
this pull request
Nov 4, 2022
* tomas/storage-read-height-bug: changelog: add #706 config: add `shell.storage_read_past_height_limit`, use it for queries storage: fix block heights used in read, write and delete rocksdb: fix delete_subspace_val diff write rocksdb: fix read_subspace_val_with_height test/storage: add a test for reading from arbitrary block heights
yito88
previously approved these changes
Nov 4, 2022
tzemanovic
added a commit
that referenced
this pull request
Nov 9, 2022
* tomas/storage-read-height-bug: rocksdb: refactor to use pattern match changelog: add #706 config: add `shell.storage_read_past_height_limit`, use it for queries storage: fix block heights used in read, write and delete rocksdb: fix delete_subspace_val diff write rocksdb: fix read_subspace_val_with_height test/storage: add a test for reading from arbitrary block heights
tzemanovic
added a commit
that referenced
this pull request
Nov 9, 2022
* tomas/storage-read-height-bug: rocksdb: refactor to use pattern match changelog: add #706 config: add `shell.storage_read_past_height_limit`, use it for queries storage: fix block heights used in read, write and delete rocksdb: fix delete_subspace_val diff write rocksdb: fix read_subspace_val_with_height test/storage: add a test for reading from arbitrary block heights
juped
pushed a commit
that referenced
this pull request
Nov 14, 2022
* tomas/storage-read-height-bug: changelog: add #706 config: add `shell.storage_read_past_height_limit`, use it for queries storage: fix block heights used in read, write and delete rocksdb: fix delete_subspace_val diff write rocksdb: fix read_subspace_val_with_height test/storage: add a test for reading from arbitrary block heights
|
fix storage height bugs and rocksdb read from arb. height and delete's diffs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #705
based on v0.9.0
v0.8.1todo:
shell.storage_read_past_height_limitset to 3600 by default