Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable run_ledger e2e test for eth-bridge-integration #523

Merged
merged 10 commits into from
Oct 14, 2022

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Sep 28, 2022

Relates to #418

 running 19 tests
test e2e::eth_bridge_tests::everything ... ignored
test e2e::gossip_tests::match_intents ... ignored
test e2e::gossip_tests::run_gossip ... ignored
test e2e::ledger_tests::invalid_transactions ... ignored
test e2e::ledger_tests::ledger_many_txs_in_a_block ... ignored
test e2e::ledger_tests::ledger_txs_and_queries ... ignored
test e2e::ledger_tests::pos_bonds ... ignored
test e2e::ledger_tests::pos_init_validator ... ignored
test e2e::ledger_tests::proposal_offline ... ignored
test e2e::ledger_tests::proposal_submission ... ignored
test e2e::ledger_tests::run_ledger ... ok <4.399s>
test e2e::ledger_tests::run_ledger_load_state_and_reset ... ignored
test e2e::ledger_tests::test_anoma_shuts_down_if_tendermint_dies ... ignored
test e2e::ledger_tests::test_genesis_validators ... ignored
test e2e::ledger_tests::test_node_connectivity ... ignored
test e2e::wallet_tests::wallet_address_cmds ... ok <0.422s>
test e2e::wallet_tests::wallet_encrypted_key_cmds ... ok <0.878s>
test e2e::wallet_tests::wallet_encrypted_key_cmds_env_var ... ok <0.854s>
test e2e::wallet_tests::wallet_unencrypted_key_cmds ... ok <0.294s>

https://github.com/anoma/namada/actions/runs/3243948741/jobs/5319410827

@james-chf james-chf changed the title Re-enable some e2e tests for eth-bridge-integration Re-enable some e2e tests for eth-bridge-integration Sep 28, 2022
@Fraccaman Fraccaman force-pushed the eth-bridge-integration branch 2 times, most recently from 8d7b66f to c285b74 Compare October 6, 2022 10:49
@james-chf james-chf force-pushed the james/ethbridge/reenable-e2e-tests branch 2 times, most recently from 0fca183 to bb7de0e Compare October 13, 2022 15:05
@james-chf james-chf changed the title Re-enable some e2e tests for eth-bridge-integration Re-enable run_ledger e2e test for eth-bridge-integration Oct 13, 2022
@james-chf
Copy link
Contributor Author

There are some other e2e tests that will pass locally like run_ledger_load_state_and_reset, that we can try re-enabling next. It was working in CI before on this PR but started failing again I think.

@james-chf james-chf marked this pull request as ready for review October 13, 2022 16:32
@sug0
Copy link
Contributor

sug0 commented Oct 14, 2022

I have another branch that fixes most tests @james-chf, check out tiago/ethbridge/fix-e2e-tests. only 2 were failing in that branch

@james-chf james-chf force-pushed the james/ethbridge/reenable-e2e-tests branch from 49db756 to 7e0a931 Compare October 14, 2022 08:29
@james-chf
Copy link
Contributor Author

james-chf commented Oct 14, 2022

I have another branch that fixes most tests @james-chf, check out tiago/ethbridge/fix-e2e-tests. only 2 were failing in that branch

can we PR that branch? If it fixes most of the tests we could get it in sooner and fix the remaining two later. The Build and Test Ethereum Bridge CI job is running now 🎊 - https://github.com/anoma/namada/actions/runs/3248521636/jobs/5329831278

@james-chf james-chf merged commit cef6398 into eth-bridge-integration Oct 14, 2022
@james-chf james-chf deleted the james/ethbridge/reenable-e2e-tests branch October 14, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants