Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display payment addresses instead of extended full viewing keys in test vectors #4436

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Feb 28, 2025

Describe your changes

An attempt to reduce the amount of screens clicked through on the hardware wallet for shielded/unshielding transactions. This is done by displaying the payment address of a note as the sender (similar to what the Zcash Ledger app does) instead of the extended full viewing key that owns it. This reduces the number of screens required to display a sender from 8 to 3. I.e. there's now 5 less screens to click though, which reduces the amount of time required to sign a shielded transaction once the display lag is considered. Alternative options were considered like displaying just a full viewing key or an incoming viewing key instead of the extended full viewing key, but these do not already have bech32 encodings in Namada nor can they be used in any of the existing interfaces. See attached what the new test vectors would look like:
testvecs_formatted.json
testdbgs.txt.gz

This PR depends upon anoma/masp#92 to obtain the payment addresses of transaction input notes.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi added the MASP label Feb 28, 2025
@murisi murisi requested a review from tzemanovic February 28, 2025 10:37
@murisi murisi added the do-not-merge Do not merge for now label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (4f94992) to head (9b44d85).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4436      +/-   ##
==========================================
- Coverage   74.52%   74.49%   -0.04%     
==========================================
  Files         339      339              
  Lines      110512   110646     +134     
==========================================
+ Hits        82364    82423      +59     
- Misses      28148    28223      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the backport-libs-0.47 Backport libraries to 0.47 maintenance branch label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.47 Backport libraries to 0.47 maintenance branch do-not-merge Do not merge for now MASP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant