Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End epochs for continuous PGF distributions #4408

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Feb 22, 2025

Describe your changes

Closes #4104

Todo:

  • update the Remove variant for cont PGF to remove by address + proposal ID

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@brentstone brentstone added the breaking:SDK SDK breaking change label Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 70 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (4558855) to head (8177ad2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/pgf/inflation.rs 31.25% 33 Missing ⚠️
crates/governance/src/finalize_block.rs 16.66% 20 Missing ⚠️
crates/governance/src/storage/proposal.rs 73.80% 11 Missing ⚠️
crates/sdk/src/signing.rs 94.11% 4 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4408      +/-   ##
==========================================
- Coverage   74.54%   74.51%   -0.03%     
==========================================
  Files         339      339              
  Lines      110504   110592      +88     
==========================================
+ Hits        82372    82407      +35     
- Misses      28132    28185      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/cpgf-end-epochs branch from 639dc1d to 8177ad2 Compare February 27, 2025 03:49
@github-actions github-actions bot added the backport-libs-0.47 Backport libraries to 0.47 maintenance branch label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.47 Backport libraries to 0.47 maintenance branch breaking:SDK SDK breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

continuous PGF proposals should have beginning and end epoch options
1 participant