-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBC rate limit query #4246
IBC rate limit query #4246
Conversation
0464530
to
8a4ba07
Compare
@brentstone I've also added a cli command for the query. Let me know if we only need the sdk function so that I can revert that change |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
==========================================
- Coverage 74.03% 74.02% -0.01%
==========================================
Files 345 345
Lines 109877 109920 +43
==========================================
+ Hits 81349 81370 +21
- Misses 28528 28550 +22 ☔ View full report in Codecov by Sentry. |
@grarco I've fixed up some things and I think the PR is rdy now |
3f0d76d
to
979fcb4
Compare
crates/apps_lib/src/client/rpc.rs
Outdated
throughput_str | ||
); | ||
} | ||
Err(_) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, given the way the ibc vp validates transactions, this logic is wrong. The sdk query_ibc_rate_limits
function returns an error if just one of the two keys is missing and in here we fallback to the default values for both, but the vp does actually support setting only one of the two and then using the default param for the other one. I'll try to rework this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9a1b9b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, gotcha!
979fcb4
to
2fdf5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 1 suggestion, otherwise lgtm
2fdf5e6
to
96d24aa
Compare
Describe your changes
Adds a query to retrieve the ibc rate limit for a specific token.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo