-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split release versions of bins and libs #4117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
approved these changes
Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 341 341
Lines 107491 107491
=======================================
+ Hits 80169 80170 +1
+ Misses 27322 27321 -1 ☔ View full report in Codecov by Sentry. |
tzemanovic
added
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
and removed
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
labels
Nov 29, 2024
tzemanovic
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Nov 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
(cherry picked from commit 63dae40)
3 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 29, 2024
split release versions of bins and libs (backport #4117)
tzemanovic
added a commit
that referenced
this pull request
Nov 29, 2024
* maint-0.46: Namada libs 0.46.1 changelog: add #4117 exclude apps crate from libs release apps: don't use workspace version anymore add a script to release apps bins prefix libs release tag with "libs-" mv scripts/release.sh scripts/release_libs.sh add different commit msg for libs release add a different release config for apps Changelog Add a single CometBFT dummy validator mergify: move autosquash to queue_rules Adds debug trace for masp epochs in asset types Fix `gen_localnet.py` json exception Revert "ci(mergify): upgrade configuration to current format" Error match for shielding retry logic Changelog #4071 Refactors shielding retry logic Shielding retry logic only when masp vp rejects Improves implicit vp display Changelog #4083 Adds missing protocol params in logs Log the implicit vp in `query-protocol-parameters` mergify: backport 0.46
tzemanovic
added a commit
that referenced
this pull request
Dec 11, 2024
* tomas/ci/test-ledger-app: ci/test-ledger-app: specify container image Point to Ledger app patched to fix decimal point and internal address issue. Format timestamps so that they exactly match hardware wallet outputs. ci: minors Minor simplifications. Added changelog entry. Make the CI run the generated test vectors through the Ledger app unit tests. fix readme links Added a changelog entry. Change the Hermes branch used by the CI. Refactors attaching signatures on wrapper dump ci: run on maint-libs PRs mergify: add apps backport rules, add prefix for libs Hide modified ZIP 32 behind a CLI flag. Downgraded the ledger-namada-rs branch. Now print error messages when MASP hardware wallet integration functionality is triggered. Test that the transfer source now displays as a viewing key. Make the the software wallet support the old Store format. Adjust integration tests to work with both hardware and localnet genesis files. update for mainnet release Namada 1.0.0 clear changelogs released in libs-v0.46.1 changelog: add #4123 Changelog #4120 Removes duplicated `sign-tx` command Adds tests for offline wrapper signature Fixes offline wrapper signature changelog: add #4117 exclude apps crate from libs release apps: don't use workspace version anymore add a script to release apps bins prefix libs release tag with "libs-" mv scripts/release.sh scripts/release_libs.sh add different commit msg for libs release add a different release config for apps Changelog Add a single CometBFT dummy validator Make shielded balance checking more robust for IBC tests. Sometimes use literals instead of aliases in the IBC tests. test/e2e/masp: add support for testing with HW wallet Always sign MASP Transactions before dumping because randomness parameters cannot be reused. Fixed MASP integration tests depending on access to secret keys. fix proposal type Dont do a dry run if using a device in the MASP integration tests. Moved the shielded keys used in the integration tests into the localnet wallet. Never use the hardware wallet to sign the fee header alone. Always ensure removal of MASP Builder data. Separate the storage of shielded keys from their birthdays. Expand MASP hardware wallet support to other transaction types. Factored out the logic for MASP hardware wallet signing. Implemented MASP signing using the hardware wallet. mergify: move autosquash to queue_rules Adds debug trace for masp epochs in asset types Revert "ci(mergify): upgrade configuration to current format" Error match for shielding retry logic Fix `gen_localnet.py` json exception Improves implicit vp display Changelog #4083 Adds missing protocol params in logs Log the implicit vp in `query-protocol-parameters` mergify: backport 0.46 Changelog #4071 Refactors shielding retry logic Shielding retry logic only when masp vp rejects Fix typos in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
crates/apps
will be versioned separately from everything else, starting atv1.0
v1.0.0
maint-1.0
scripts/release_bins.sh
apps
may be preceded bylibs
release with thelibs
release backported to theapps
maintenance branchv0.46.0
libs-
, e.g. next patch release tag would belibs-v.46.1
maint-libs-0.46
scripts/release_libs.sh
libs
can be released independently ofapps
at any timeCHANGELOG.md
in their release order and the libs release versions will be prefixed withlibs-
to distinguish themapps
releases will usually have their changes coming from the libs, their changelog may often only contain e.g.updated namada libraries to libs-vX.Y.Z
backport-lib-X.Y
for libs andbackport-X.Y
for appscrates/apps
is a very thin layer of main fns which dispatch most of their functionality tocrates/apps_lib
Updated release process
main
libs-vX.Y.Z
into apps maint branch before release (never merge unreleased libs branches here, such as a libs maintenance branch)updated namada libraries to libs-vX.Y.Z
to serve as a link to the change set from libsmain
and then mergemain
into latestmaint-libs-X.Y
maint-libs-X.Y
updated namada libraries to libs-vX.Y.Z
to serve as a link to the change set from libsmaint-X.Y
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo