Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single CometBFT dummy validator #4116

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 29, 2024

Describe your changes

Closes #4096

Only writes a dummy validator to CometBFT's genesis if the number of validators present is lower than 2.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Only writes a dummy validator to CometBFT's genesis if the number of
validators present is lower than 2.
@sug0 sug0 added bug Something isn't working ledger labels Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (c61bbe0) to head (1021625).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/tendermint_node.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
- Coverage   74.58%   74.57%   -0.01%     
==========================================
  Files         341      341              
  Lines      107491   107495       +4     
==========================================
  Hits        80169    80169              
- Misses      27322    27326       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco
Copy link
Collaborator

grarco commented Nov 29, 2024

I believe this closes #4096 unless we want to remove that command anyway

@tzemanovic tzemanovic added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass backport-libs-0.46 Backport libraries to 0.46 maintenance branch labels Nov 29, 2024
@mergify mergify bot merged commit 1362f34 into main Nov 29, 2024
22 of 24 checks passed
@mergify mergify bot deleted the tiago/comet-genesis-validator-set branch November 29, 2024 16:20
mergify bot added a commit that referenced this pull request Nov 29, 2024
Add a single CometBFT dummy validator (backport #4116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.46 Backport libraries to 0.46 maintenance branch bug Something isn't working ledger merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update_db validator set bug
3 participants