Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds debug trace for masp epochs in asset types #4101

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Nov 26, 2024

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@grarco grarco added MASP non-breaking-change backport-libs-0.46 Backport libraries to 0.46 maintenance branch labels Nov 26, 2024
@grarco grarco requested a review from Fraccaman November 26, 2024 17:05
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.58%. Comparing base (10dfb2f) to head (2446847).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/shielded_token/src/masp/shielded_wallet.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4101      +/-   ##
==========================================
- Coverage   74.58%   74.58%   -0.01%     
==========================================
  Files         341      341              
  Lines      107484   107488       +4     
==========================================
+ Hits        80166    80168       +2     
- Misses      27318    27320       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 29, 2024
mergify bot added a commit that referenced this pull request Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

Hey @grarco, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Nov 29, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Nov 29, 2024
mergify bot added a commit that referenced this pull request Nov 29, 2024
@mergify mergify bot merged commit a54a681 into main Nov 29, 2024
22 of 24 checks passed
@mergify mergify bot deleted the grarco/trace-masp-epoch branch November 29, 2024 10:11
mergify bot added a commit that referenced this pull request Nov 29, 2024
Adds debug trace for masp epochs in asset types (backport #4101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.46 Backport libraries to 0.46 maintenance branch MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants