-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gas messages #3928
Merged
Merged
Improve gas messages #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
+ Coverage 73.34% 73.41% +0.06%
==========================================
Files 341 341
Lines 105522 105670 +148
==========================================
+ Hits 77400 77577 +177
+ Misses 28122 28093 -29 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/improve-gas-msgs
branch
from
October 18, 2024 17:21
5ff364f
to
9e807be
Compare
brentstone
approved these changes
Oct 22, 2024
brentstone
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Oct 22, 2024
3 tasks
mergify bot
added a commit
that referenced
this pull request
Oct 22, 2024
Improve gas messages (backport #3928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
non-breaking-change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improves the gas error messages we emit from mempool validation and process proposal.
Adds two new unit tests.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo