Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gas messages #3928

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Improve gas messages #3928

merged 4 commits into from
Oct 22, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Oct 18, 2024

Describe your changes

Improves the gas error messages we emit from mempool validation and process proposal.
Adds two new unit tests.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

grarco added a commit that referenced this pull request Oct 18, 2024
@grarco grarco marked this pull request as ready for review October 18, 2024 16:43
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 99.05660% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.41%. Comparing base (051ec84) to head (9e807be).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/shell/process_proposal.rs 98.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3928      +/-   ##
==========================================
+ Coverage   73.34%   73.41%   +0.06%     
==========================================
  Files         341      341              
  Lines      105522   105670     +148     
==========================================
+ Hits        77400    77577     +177     
+ Misses      28122    28093      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 22, 2024
mergify bot added a commit that referenced this pull request Oct 22, 2024
@mergify mergify bot merged commit 03e986c into main Oct 22, 2024
24 checks passed
@mergify mergify bot deleted the grarco/improve-gas-msgs branch October 22, 2024 02:28
mergify bot pushed a commit that referenced this pull request Oct 22, 2024
(cherry picked from commit 9e807be)
@mergify mergify bot mentioned this pull request Oct 22, 2024
3 tasks
mergify bot added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants