Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce event's masp attributes #3826

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Reduce event's masp attributes #3826

merged 5 commits into from
Sep 19, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Sep 18, 2024

Describe your changes

Closes #3824.

Reduces the number of a tx event's masp attributes down to a single one.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo

@grarco grarco changed the title Simplify event's masp attributes Reduce event's masp attributes Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.82%. Comparing base (28ebf30) to head (297ee26).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3826      +/-   ##
==========================================
- Coverage   72.82%   72.82%   -0.01%     
==========================================
  Files         338      338              
  Lines      104230   104220      -10     
==========================================
- Hits        75909    75901       -8     
+ Misses      28321    28319       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review September 18, 2024 16:24
@grarco grarco requested a review from tzemanovic September 18, 2024 17:00
@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 19, 2024
@mergify mergify bot merged commit e29da65 into main Sep 19, 2024
25 of 38 checks passed
@mergify mergify bot deleted the grarco/reduce-masp-events branch September 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:SDK merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce masp events
2 participants