Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify MASP refs events #3821

Merged
merged 9 commits into from
Sep 18, 2024

Masp tx extraction refactor + reduced type verbosity

561f604
Select commit
Loading
Failed to load commit list.
Merged

Unify MASP refs events #3821

Masp tx extraction refactor + reduced type verbosity
561f604
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 18, 2024 in 0s

72.80% (+0.01%) compared to e603759

View this Pull Request on Codecov

72.80% (+0.01%) compared to e603759

Details

Codecov Report

Attention: Patch coverage is 74.17582% with 47 lines in your changes missing coverage. Please review.

Project coverage is 72.80%. Comparing base (e603759) to head (561f604).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/masp.rs 42.37% 34 Missing ⚠️
crates/sdk/src/masp/utilities.rs 80.00% 6 Missing ⚠️
crates/core/src/masp.rs 0.00% 3 Missing ⚠️
crates/node/src/protocol.rs 90.00% 1 Missing ⚠️
...hielded_token/src/masp/shielded_sync/dispatcher.rs 97.56% 1 Missing ⚠️
crates/shielded_token/src/masp/shielded_wallet.rs 95.45% 1 Missing ⚠️
crates/tx/src/types.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3821      +/-   ##
==========================================
+ Coverage   72.79%   72.80%   +0.01%     
==========================================
  Files         338      338              
  Lines      103995   103989       -6     
==========================================
+ Hits        75701    75708       +7     
+ Misses      28294    28281      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov