Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tendermint-rs reexports #3697

Merged
merged 2 commits into from
Aug 28, 2024
Merged

refactor tendermint-rs reexports #3697

merged 2 commits into from
Aug 28, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Aug 23, 2024

Describe your changes

Depends-On: #3670

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

tzemanovic added a commit that referenced this pull request Aug 23, 2024
tzemanovic added a commit that referenced this pull request Aug 23, 2024
@tzemanovic tzemanovic force-pushed the tomas/refactor-tm-reexports branch from 4c6424a to 7d449b1 Compare August 23, 2024 12:43
@tzemanovic tzemanovic requested a review from sug0 August 23, 2024 12:44
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 25.42373% with 44 lines in your changes missing coverage. Please review.

Project coverage is 61.50%. Comparing base (62be903) to head (a899f28).
Report is 3 commits behind head on main.

Files Patch % Lines
...node/src/shell/vote_extensions/bridge_pool_vext.rs 0.00% 11 Missing ⚠️
...rates/node/src/shell/vote_extensions/eth_events.rs 0.00% 11 Missing ⚠️
...s/node/src/shell/vote_extensions/val_set_update.rs 0.00% 11 Missing ⚠️
crates/node/src/shell/init_chain.rs 20.00% 8 Missing ⚠️
crates/events/src/extend.rs 0.00% 1 Missing ⚠️
crates/node/src/shell/testing/client.rs 0.00% 1 Missing ⚠️
crates/node/src/shims/abcipp_shim.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
- Coverage   61.51%   61.50%   -0.01%     
==========================================
  Files         315      315              
  Lines      103880   103879       -1     
==========================================
- Hits        63898    63891       -7     
- Misses      39982    39988       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}
/// Re-export of tendermint-proto v0.37
pub mod tendermint_proto {
pub use tendermint_proto::google; // 💩
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩💩💩

@tzemanovic
Copy link
Member Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Aug 27, 2024

refresh

✅ Pull request refreshed

@tzemanovic
Copy link
Member Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Aug 27, 2024

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Aug 27, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

@tzemanovic tzemanovic mentioned this pull request Aug 27, 2024
1 task
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 27, 2024
@Fraccaman
Copy link
Member

@mergify refresh

Copy link
Contributor

mergify bot commented Aug 28, 2024

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Aug 28, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CONFLICT_WITH_BASE_BRANCH.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

tzemanovic added a commit that referenced this pull request Aug 28, 2024
@tzemanovic tzemanovic force-pushed the tomas/refactor-tm-reexports branch from 7d449b1 to 2eaf06a Compare August 28, 2024 10:17
@tzemanovic tzemanovic force-pushed the tomas/refactor-tm-reexports branch from 2eaf06a to a899f28 Compare August 28, 2024 10:46
@mergify mergify bot merged commit 2aef1e7 into main Aug 28, 2024
20 of 22 checks passed
@mergify mergify bot deleted the tomas/refactor-tm-reexports branch August 28, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only re-export current CometBFT version in use
3 participants