-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token: fix transfer to self #3675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
==========================================
+ Coverage 61.12% 61.18% +0.05%
==========================================
Files 315 315
Lines 103056 103168 +112
==========================================
+ Hits 62994 63121 +127
+ Misses 40062 40047 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the transfer to self has to be a no-op cause it's used from protocol where it shouldn't fail otherwise a tx might get wrongly rejected
9d1b1b3
to
a00749c
Compare
a00749c
to
f5268cd
Compare
Describe your changes
To make things easier, lets make transfer fails if
source == dest
Checklist before merging
breaking::
labels