Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token: fix transfer to self #3675

Merged
merged 2 commits into from
Aug 21, 2024
Merged

token: fix transfer to self #3675

merged 2 commits into from
Aug 21, 2024

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Aug 20, 2024

Describe your changes

To make things easier, lets make transfer fails if source == dest

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (b7d2db3) to head (f5268cd).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3675      +/-   ##
==========================================
+ Coverage   61.12%   61.18%   +0.05%     
==========================================
  Files         315      315              
  Lines      103056   103168     +112     
==========================================
+ Hits        62994    63121     +127     
+ Misses      40062    40047      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman marked this pull request as ready for review August 20, 2024 11:53
@Fraccaman Fraccaman requested a review from tzemanovic August 20, 2024 13:26
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the transfer to self has to be a no-op cause it's used from protocol where it shouldn't fail otherwise a tx might get wrongly rejected

@Fraccaman Fraccaman requested a review from tzemanovic August 20, 2024 16:52
@tzemanovic tzemanovic force-pushed the fraccaman/test-token-funcs branch from 9d1b1b3 to a00749c Compare August 21, 2024 11:02
@tzemanovic tzemanovic force-pushed the fraccaman/test-token-funcs branch from a00749c to f5268cd Compare August 21, 2024 11:03
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 21, 2024
mergify bot added a commit that referenced this pull request Aug 21, 2024
@mergify mergify bot merged commit 2a3a5c8 into main Aug 21, 2024
21 checks passed
@mergify mergify bot deleted the fraccaman/test-token-funcs branch August 21, 2024 12:19
@brentstone brentstone mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking: protocol merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants