Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: remove wasm downloader #3598

Merged
merged 2 commits into from
Aug 9, 2024
Merged

ledger: remove wasm downloader #3598

merged 2 commits into from
Aug 9, 2024

Conversation

Fraccaman
Copy link
Member

Describe your changes

We are now shipping wasm artifacts together with the chain setup, no need to let the node download artifacts from an untrusted source.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.56%. Comparing base (682d7ff) to head (793f4a4).
Report is 17 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/wasm_loader/mod.rs 0.00% 10 Missing ⚠️
crates/apps_lib/src/client/utils.rs 0.00% 4 Missing ⚠️
crates/node/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
+ Coverage   54.53%   54.56%   +0.03%     
==========================================
  Files         323      323              
  Lines      113879   113819      -60     
==========================================
+ Hits        62108    62111       +3     
+ Misses      51771    51708      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman marked this pull request as ready for review August 9, 2024 09:21
crates/node/src/lib.rs Outdated Show resolved Hide resolved
@Fraccaman Fraccaman force-pushed the fraccaman/remove-wasm-loader branch from 70d1083 to 793f4a4 Compare August 9, 2024 10:42
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 9, 2024
mergify bot added a commit that referenced this pull request Aug 9, 2024
@mergify mergify bot merged commit ee5140a into main Aug 9, 2024
20 of 21 checks passed
@mergify mergify bot deleted the fraccaman/remove-wasm-loader branch August 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants