parameters/max_block_time: fallback to parameters only when no blocks

[tzemanovic]

Describe your changes

The value estimated from parameters might be very off when the configured epoch duration is proportionally much longer than the min number of blocks in epoch in respect to block duration from configured by timeout_commit (comet consensus config)

Indicate on which release or other PRs this topic is based on

0.41.0

Checklist before merging to draft

• I have added a changelog
• Git history is in acceptable state

[tzemanovic]

@mateuszjasiuk

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.54%. Comparing base (6d3fc90) to head (4f584de).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3591      +/-   ##
==========================================
- Coverage   54.55%   54.54%   -0.01%     
==========================================
  Files         323      323              
  Lines      113851   113842       -9     
==========================================
- Hits        62106    62098       -8     
+ Misses      51745    51744       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mateuszjasiuk]

LGTM!

[Fraccaman]

wanna go ahead and merge? @tzemanovic