Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IBC client upgrade test #3573

Merged
merged 17 commits into from
Aug 14, 2024
Merged

Add IBC client upgrade test #3573

merged 17 commits into from
Aug 14, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jul 31, 2024 •
edited
Loading

Describe your changes

closes #3535

  • Added a new E2E test ibc_upgrade_client
    • Added a wasm tx_proposal_ibc_client_upgrade for testing to store the IBC client state and consensus state to be used in the counterparty chain
  • Moved COMMITMENT_PREFIX

Indicate on which release or other PRs this topic is based on

v0.41.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (4cd4356) to head (5136a3b).

Files Patch % Lines
crates/ibc/src/storage.rs 0.00% 19 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3573      +/-   ##
==========================================
- Coverage   61.24%   61.23%   -0.02%     
==========================================
  Files         312      312              
  Lines      101374   101394      +20     
==========================================
+ Hits        62086    62087       +1     
- Misses      39288    39307      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman
Copy link
Member

which version of gaia do we need?

@yito88
Copy link
Member Author

yito88 commented Jul 31, 2024 •
edited
Loading

I'm testing with Gaia v17 for now because Hermes is using the version for testing

@Fraccaman
Copy link
Member

Fraccaman commented Jul 31, 2024 •
edited
Loading

okay then we have to upgrade gaia, right now CI is using 15 I think

@yito88 yito88 force-pushed the yuji/ibc-client-upgrade-test branch 2 times, most recently from c21c0e3 to ece67df Compare July 31, 2024 21:44
@yito88 yito88 marked this pull request as draft August 1, 2024 13:48
@yito88 yito88 force-pushed the yuji/ibc-client-upgrade-test branch from a7b188e to 90b52e1 Compare August 8, 2024 14:28
@yito88 yito88 marked this pull request as ready for review August 9, 2024 09:19
@yito88 yito88 requested review from sug0 and grarco August 9, 2024 12:50
grarco
grarco reviewed Aug 9, 2024
View reviewed changes
crates/tests/src/e2e/ibc_tests.rs Outdated
// first height of the grace epoch. It is set 340 because the grace epoch in
// this test will be Epoch 18 and the number of blocks per epoch is 20.
const MIN_UPGRADE_HEIGHT: u64 = 340;
const MASP_EPOCH_MULTIPLIER: u64 = 2;
Copy link
Collaborator

@grarco grarco Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can avoid setting a custom masp epoch multiplier for this test

grarco
grarco reviewed Aug 9, 2024
View reviewed changes
wasm_for_tests/tx_proposal_ibc_client_upgrade/Cargo.toml
@@ -0,0 +1,26 @@
[package]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me like there are a bunch of dependencies that might not be needed, but this is something that extends to all the wasm for tests, I'll open an issue to track this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked here #3606

@tzemanovic tzemanovic mentioned this pull request Aug 13, 2024
Merged
1 task
@sug0 sug0 self-requested a review August 13, 2024 12:33
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
@mergify
Merge of #3573
807961c
@mergify mergify bot mentioned this pull request Aug 13, 2024
Closed
mergify bot added a commit that referenced this pull request Aug 13, 2024
@mergify
Merge of #3573
1a4eb86
@mergify mergify bot mentioned this pull request Aug 13, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 13, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 13, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 13, 2024
@mergify
Merge of #3573
e3626bf
@mergify mergify bot mentioned this pull request Aug 13, 2024
Closed
mergify bot added a commit that referenced this pull request Aug 13, 2024
@mergify
Merge of #3573
0c68830
@mergify mergify bot mentioned this pull request Aug 13, 2024
Closed
mergify bot added a commit that referenced this pull request Aug 13, 2024
@mergify
Merge of #3573
acedbe1
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 13, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@Fraccaman Fraccaman removed the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 14, 2024
@tzemanovic tzemanovic force-pushed the yuji/ibc-client-upgrade-test branch from c2d4f05 to 2727135 Compare August 14, 2024 13:21
@tzemanovic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 14, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@tzemanovic tzemanovic force-pushed the yuji/ibc-client-upgrade-test branch from 2727135 to 5136a3b Compare August 14, 2024 13:34
@tzemanovic
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 14, 2024

refresh

✅ Pull request refreshed

@tzemanovic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 14, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 14, 2024
@mergify mergify bot merged commit 9fb1037 into main Aug 14, 2024
20 of 21 checks passed
@mergify mergify bot deleted the yuji/ibc-client-upgrade-test branch August 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco left review comments

@sug0 sug0 sug0 approved these changes

Assignees
No one assigned
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No test for IBC client upgrade
5 participants
@yito88 @Fraccaman @tzemanovic @sug0 @grarco