Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use total active voting power in query_proposal_result #3540

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Jul 19, 2024

Describe your changes

Need to use the total active voting power instead of total deltas inside fn query_proposal_result.

Closes #3532.

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone added bug Something isn't working governance labels Jul 19, 2024
@brentstone brentstone mentioned this pull request Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (8479d38) to head (6b13409).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/rpc.rs 0.00% 13 Missing ⚠️
crates/sdk/src/queries/vp/pos.rs 0.00% 12 Missing ⚠️
crates/governance/src/utils.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3540      +/-   ##
==========================================
- Coverage   53.48%   53.46%   -0.03%     
==========================================
  Files         320      320              
  Lines      110000   110021      +21     
==========================================
- Hits        58832    58819      -13     
- Misses      51168    51202      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone marked this pull request as ready for review July 22, 2024 23:38
@brentstone brentstone requested a review from Fraccaman July 22, 2024 23:39
Fraccaman
Fraccaman previously approved these changes Jul 23, 2024
brentstone added a commit that referenced this pull request Jul 24, 2024
* brent/fix-query-proposal-result-vp:
  changelog: add #3540
  improve tally descriptions
  correct tally requirement for steward funding submission
  use total active stake in query_proposal_result
@brentstone brentstone merged commit 99cb0d2 into main Jul 24, 2024
17 of 19 checks passed
@brentstone brentstone deleted the brent/fix-query-proposal-result-vp branch July 24, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working governance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All pgf internal address tokens drained with a pgf payment proposal
2 participants