core: checked arithmetics #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/checked-arith
branch
2 times, most recently
from
6348ce5 to
a1213b2
Compare
tzemanovic
force-pushed
the
tomas/checked-arith
branch
from
a1213b2 to
aafb5d1
Compare
tzemanovic
force-pushed
the
tomas/checked-arith
branch
2 times, most recently
from
a560edb to
f7064f2
Compare
tzemanovic
force-pushed
the
tomas/checked-arith
branch
3 times, most recently
from
0f9e1e0 to
a38747b
Compare
tzemanovic
force-pushed
the
tomas/checked-arith
branch
from
a38747b to
0a001b5
Compare
tzemanovic
force-pushed
the
tomas/checked-arith
branch
from
0a001b5 to
1569518
Compare
tzemanovic
force-pushed
the
tomas/checked-arith
branch
2 times, most recently
from
871ae3c to
128bf14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
==========================================
+ Coverage 59.40% 59.53% +0.12%
==========================================
Files 298 298
Lines 92326 92613 +287
==========================================
+ Hits 54849 55138 +289
+ Misses 37477 37475 -2 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/checked-arith
branch
from
128bf14 to
30c5c50
Compare
tzemanovic
added a commit
that referenced
this pull request
May 3, 2024
|
@tzemanovic Is the title of this PR still accurate? Looks like a bunch of crates beyond core are changed. Does this cover everything, everywhere or are there other sections still remaining to transition to checked arithemetic? |
brentstone
reviewed
May 6, 2024
| let raw = I256::try_from(amt.raw_amount()) | ||
| .map_err(|e| eyre!("Invalid raw amount: {e}"))?; | ||
| let denom = I256(Uint::exp10( | ||
| (POS_DECIMAL_PRECISION - NATIVE_MAX_DECIMAL_PLACES) as usize, |
There was a problem hiding this comment.
I'm sure we're safe to do this operation but figured I'd point it out as possibly unchecked
There was a problem hiding this comment.
it's ok as they're both consts and the fn is also covered by unit tests
brentstone
reviewed
May 7, 2024
crates/core/src/token.rs
Outdated
| impl From<Dec> for Amount { | ||
| fn from(dec: Dec) -> Amount { | ||
| impl TryFrom<Dec> for Amount { | ||
| type Error = (); |
There was a problem hiding this comment.
why () for the Error type?
There was a problem hiding this comment.
ah, I'll switch it to use arith err
tzemanovic
force-pushed
the
tomas/checked-arith
branch
from
70daab5 to
a78ec98
Compare
tzemanovic
added a commit
that referenced
this pull request
May 8, 2024
* tomas/checked-arith: changelog: add #3074 namada/pos: re-use into_tm_voting_power from pos crate wasm: update to non-panicking core API benches: update to non-panicking core API apps: update to non-panicking core API namada: update to non-panicking core API sdk: update to non-panicking core API eth_bridge: update to non-panicking core API ibc: update to non-panicking core API pos: update to non-panicking core API gov: update to non-panicking core API state: update to non-panicking core API shielded_token: update to non-panicking core API trans_token: update to non-panicking core API vote_ext: update to non-panicking core API controller: replacing panicking code storage/collections/lazy_map: add try_update storage: add conv from core::arith::Error for convenience test/core: fixes for checked arith core: clippy fixes core/dec: sanitize panicking code core/storage: sanitize panicking code core/token: sanitize panicking code core/uint: sanitize panicking code core: add `assert_matches` dev-dep core/voting_power: sanitize panicking code core: strict clippy arith deps: add smooth-operator and re-export from core/arith core: add arith mod with a custom `trait CheckedAdd`
tzemanovic
added a commit
that referenced
this pull request
May 8, 2024
brentstone
added a commit
that referenced
this pull request
May 8, 2024
* origin/tomas/checked-arith: changelog: add #3074 namada/pos: re-use into_tm_voting_power from pos crate wasm: update to non-panicking core API benches: update to non-panicking core API apps: update to non-panicking core API namada: update to non-panicking core API sdk: update to non-panicking core API eth_bridge: update to non-panicking core API ibc: update to non-panicking core API pos: update to non-panicking core API gov: update to non-panicking core API state: update to non-panicking core API shielded_token: update to non-panicking core API trans_token: update to non-panicking core API vote_ext: update to non-panicking core API controller: replacing panicking code storage/collections/lazy_map: add try_update storage: add conv from core::arith::Error for convenience test/core: fixes for checked arith core: clippy fixes core/dec: sanitize panicking code core/storage: sanitize panicking code core/token: sanitize panicking code core/uint: sanitize panicking code core: add `assert_matches` dev-dep core/voting_power: sanitize panicking code core: strict clippy arith deps: add smooth-operator and re-export from core/arith core: add arith mod with a custom `trait CheckedAdd`
brentstone
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
first part of #2555 addressing core crate
Indicate on which release or other PRs this topic is based on
v0.34.0
Checklist before merging to
draft