test/e2e/init_validator: restart new validator node right after its tx #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Apr 8, 2024
* tomas/e2e-pos-init-validator-fix: test/e2e/init_validator: restart new validator node right after its tx
brentstone
approved these changes
Apr 8, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/tomas/e2e-pos-init-validator-fix: test/e2e/init_validator: restart new validator node right after its tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The test often fails with
InsufficientVoteson the first node as the second validator is bonded with the same stake and when it's not signing by the time it enters the consensus set we don't get enough votes to continue.To fix this I moved the calls to restart the new validator's node right after its
init-validatortx.Indicate on which release or other PRs this topic is based on
v0.32.1
Checklist before merging to
draft[ ] I have added a changelog- tests only