VP update using actions enum written by txs to a temp storage #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
- Coverage 53.88% 53.00% -0.88%
==========================================
Files 308 313 +5
Lines 100154 102459 +2305
==========================================
+ Hits 53966 54309 +343
- Misses 46188 48150 +1962 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/tx-actions
branch
4 times, most recently
from
a3a8069
to
1e36094
Compare
2 tasks
tzemanovic
force-pushed
the
tomas/tx-actions
branch
from
1e36094
to
f1892fd
Compare
tzemanovic
changed the title
This change permits error messages to be encoded in the `Err` branch of `Result` types, to facilitate debugging in case of software problems, and to improve the user experience in Namada.
* origin/tiago/wasm-errs-ux: Changelog for #2940 Remove explicit out-of-gas checks during VP execution Rebuild wasms for tests Return a result of unit from VPs rather than of bools Extend bools and results with new helper methods Changelog for #2852 Remove `eyre` from Ethereum Bridge Pool VP Remove `eyre` from NUT VP Remove `eyre` from Ethereum Bridge VP Remove `eyre` from Ethereum Bridge param errs Add a simple allocated storage err
tzemanovic
force-pushed
the
tomas/tx-actions
branch
3 times, most recently
from
a75bd9c
to
4cc8cbd
Compare
* tomas/ibc-tx-simplify: changelog: add #2848 ibc/tx: rm compatibility wrapper
tzemanovic
force-pushed
the
tomas/tx-actions
branch
from
e791f4c
to
bf1278d
Compare
tzemanovic
force-pushed
the
tomas/tx-actions
branch
from
55219d6
to
41ef686
Compare
tzemanovic
force-pushed
the
tomas/tx-actions
branch
from
41ef686
to
b2aabf4
Compare
tzemanovic
commented
Apr 1, 2024
| @@ -506,33 +511,12 @@ impl WriteLog { | |||
|
|
|||
| // get changed keys grouped by the address | |||
| for key in changed_keys.iter() { | |||
| // for token keys, trigger Multitoken VP and the owner's VP | |||
| // | |||
| // TODO: this should not be a special case, as it is error prone. | |||
There was a problem hiding this comment.
this is now checked in crates/namada/src/ledger/native_vp/multitoken.rs
tzemanovic
commented
Apr 1, 2024
| @@ -145,6 +145,20 @@ where | |||
| all_tokens.extend(dec_mints.keys().cloned()); | |||
|
|
|||
| all_tokens.iter().try_for_each(|token| { | |||
| if token.is_internal() | |||
There was a problem hiding this comment.
this replaces the special token addresses "redirect" from crates/state/src/write_log.rs
yito88
approved these changes
Apr 3, 2024
2 tasks
tzemanovic
added a commit
that referenced
this pull request
Apr 9, 2024
* origin/tomas/tx-actions: changelog: add #2934 wasm/vp_implicit+vp_user: re-order to read the main entrypoint first IBC: insert NUT token as verifier in IBC transfer wasm/vp_implicit+vp_user: update using tx action vp_prelude: re-export tx mod multitoken: replace write_log specialization with standard VP rules pgf: add tx actions to check authorization gov: add tx actions to check authorization write_log: skip temp storage keys in changed keys set native_vp/PoS: update to use actions from txs tx_prelude/pos: push tx actions to indicate to VP namada/vm/host_env: add `tx_read_temp` tx,vp_prelude,native_vp: impl tx action Read/Write traits tx: add actions to indicate them from tx to VPs core/address: add `InternalAddress::TempStorage` Changelog for #2940 Remove explicit out-of-gas checks during VP execution Rebuild wasms for tests Return a result of unit from VPs rather than of bools
tzemanovic
added a commit
that referenced
this pull request
Apr 9, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 9, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/tomas/tx-actions: changelog: add #2934 wasm/vp_implicit+vp_user: re-order to read the main entrypoint first IBC: insert NUT token as verifier in IBC transfer wasm/vp_implicit+vp_user: update using tx action vp_prelude: re-export tx mod multitoken: replace write_log specialization with standard VP rules pgf: add tx actions to check authorization gov: add tx actions to check authorization write_log: skip temp storage keys in changed keys set native_vp/PoS: update to use actions from txs tx_prelude/pos: push tx actions to indicate to VP namada/vm/host_env: add `tx_read_temp` tx,vp_prelude,native_vp: impl tx action Read/Write traits tx: add actions to indicate them from tx to VPs core/address: add `InternalAddress::TempStorage` Changelog for #2940 Remove explicit out-of-gas checks during VP execution Rebuild wasms for tests Return a result of unit from VPs rather than of bools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #2629
VPs that are being updated to check action authorization:
Additionally, we can simplify logic in:
Indicate on which release or other PRs this topic is based on
based on #2928 + #2940 + #2848
diffs:
Checklist before merging to
draft