Migrated many e2e tests to integration tests #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
force-pushed
the
bat/feat/migrate-e2e-to-int
branch
from
d12880c
to
a0c27de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
==========================================
+ Coverage 53.44% 61.27% +7.82%
==========================================
Files 310 290 -20
Lines 101574 88584 -12990
==========================================
- Hits 54288 54280 -8
+ Misses 47286 34304 -12982 ☔ View full report in Codecov by Sentry. |
batconjurer
force-pushed
the
bat/feat/migrate-e2e-to-int
branch
from
eac3d77
to
3916f12
Compare
tzemanovic
reviewed
Apr 4, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 4, 2024
* origin/bat/feat/migrate-e2e-to-int: Formatting Formatting Putting duct tape over a mysterious race condition in integrations tests Added logging to MockNode for when broadcasting a tx fails Added logging to MockNode for when broadcasting a tx fails Rebuilding tests wasms, updating gitflows [fix]: Fixing broken unit test formatting Rebasinga and adding changelog [feat]: Migrated many e2e test to integration tests
tzemanovic
added a commit
that referenced
this pull request
Apr 4, 2024
|
To consider for future related work: how difficult is it to set up these integration tests with multiple validators? |
brentstone
previously approved these changes
Apr 6, 2024
It's not obvious to me how to do it. I suspect it is hard. |
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/bat/feat/migrate-e2e-to-int: Update .changelog/unreleased/improvements/2933-migrated-e2e-to-int.md Formatting Formatting Putting duct tape over a mysterious race condition in integrations tests Added logging to MockNode for when broadcasting a tx fails Added logging to MockNode for when broadcasting a tx fails Rebuilding tests wasms, updating gitflows [fix]: Fixing broken unit test formatting Rebasinga and adding changelog [feat]: Migrated many e2e test to integration tests # Conflicts: # crates/apps/src/lib/node/ledger/shell/governance.rs # crates/apps/src/lib/node/ledger/shell/testing/node.rs # crates/tests/src/e2e/ledger_tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2661
Closes #2927
This PR moves many e2e tests over to integration test. In the future, it may be possible to move more tests over. Moving some of these tests over revealed issues and these have also been resolved, including #2927.
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft