Generate Tx Borsh schema #2931
Merged
Generate Tx Borsh schema #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
- Coverage 53.44% 53.44% -0.01%
==========================================
Files 310 310
Lines 101574 101580 +6
==========================================
+ Hits 54288 54289 +1
- Misses 47286 47291 +5 ☔ View full report in Codecov by Sentry. |
murisi
force-pushed
the
murisi/generate-tx-schema
branch
2 times, most recently
from
09dc566
to
582537d
Compare
murisi
force-pushed
the
murisi/generate-tx-schema
branch
from
582537d
to
f173228
Compare
murisi
force-pushed
the
murisi/generate-tx-schema
branch
from
f173228
to
3636c41
Compare
sug0
approved these changes
Mar 25, 2024
tzemanovic
approved these changes
Mar 25, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* murisi/generate-tx-schema: Added a changelog entry. Generate Tx Borsh schema using the latest MASP schema, whilst avoiding name collissions.
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/murisi/generate-tx-schema: Added a changelog entry. Generate Tx Borsh schema using the latest MASP schema, whilst avoiding name collissions. # Conflicts: # crates/apps/src/lib/bench_utils.rs # crates/apps/src/lib/node/ledger/shell/finalize_block.rs # crates/apps/src/lib/node/ledger/shell/prepare_proposal.rs # crates/apps/src/lib/node/ledger/shell/process_proposal.rs # crates/sdk/src/tx.rs # crates/tx/src/data/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Made the necessary changes to successfully generate an accurate
TxBorsh schema. This is useful for describing the transaction format to external collaborators. More specifically, the changes were as follows:Txschema to a fileNote: Because the MASP crate update fixes serialization of a certain
Transactioncomponent in corner cases, this PR is breaking.Indicate on which release or other PRs this topic is based on
Namada v0.32.0
Checklist before merging to
draft