open_genesis_config should return a human-friendly error #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tomas/update-bin-names: cli: update binary names dispatch for namada [ci] docker use rust:1.61.0 update wasm checksums [ci] run specific step in docker container
* tomas/update-changelog-config: update the changelog config to namada repo
* tomas/e2e-fix-cmd-assert: changelog: add #247 test/e2e: update assert_success/failure to first consume output
* tomas/remove-abci: [ci] wasm checksums update ledger: debug log some ABCI++ requests ledger: make prepare_proposal and process_proposal stateless ledger: refactor tx_queue scripts/get_tendermint: update for ABCI++ temp fork release test/e2e/ledger: enable ignored tests for ABCI++ workaround shell: process transaction when `ProcessProposal` hasn't (non-validator) make: remove "*-abci-plus-plus" all: remove "ABCI" conditional compilation deps: remove ABCI dependencies, use ABCI++ as default
* fraccaman+tomas/ci-e2e-validator-logs: [ci] improve e2e log upload to add validator logs
* tomas/expectrl-switch-from-fork: changelog: add #1142 switch from a fork to expectrl v0.5.2
tzemanovic
added a commit
that referenced
this pull request
Aug 19, 2022
* james/genesis-config-error: Add changelog open_genesis_config should return a human-friendly error
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
* feat: transfers from shielded addresses * fix: support shielded transfers in FF * refactor: fix unwraps * feat: point namada to rev instead of branch * feat: masp params fetch url * feat: PathBuf instead of wasm files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from anoma/anoma#1176
depends on #250
Give a slightly better error message when
anomacoranomawcommands are run, but a chain hasn't been joined. Before we would just getNo such file or directory (os error 2), now we should indicate that specifically we can't read a genesis config file.This PR also makes some changes such that we can propagate an error all the way back up to
main()ofanomac,anoman,anomaw, so that it will be easier in the future to propagate errors like this. (Relates to anoma/anoma#1049)To close #97, we should catch the error and translate it to a friendly message such as one indicating to the user to join a network first, rather than panicking with a backtrace.