Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make some .gitignore patterns relative to repo root #289

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

tzemanovic
Copy link
Member

moved from anoma/anoma#1158

based on #250

The anoma-*/ pattern was in .gitignore, which meant there was a warning when trying to stage changes to files under apps/src/bin/anoma-* eg apps/src/bin/anoma-client/main.rs. After having edited that file and run the following:

$ git add apps/src/bin/anoma-client/main.rs

There was a warning:

The following paths are ignored by one of your .gitignore files:
apps/src/bin/anoma-client
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

This PR changes some patterns in .gitignore to have to be relative from the root of the repo.

@tzemanovic tzemanovic marked this pull request as ready for review August 8, 2022 14:40
@tzemanovic tzemanovic force-pushed the james/misc/gitgnore-anoma branch from 86501b4 to 8593feb Compare August 17, 2022 06:44
This avoid some potential conflicts with actual files we want to track

eg apps/src/bin/anoma-client/main.rs
@tzemanovic tzemanovic force-pushed the james/misc/gitgnore-anoma branch from 8593feb to 07876b1 Compare August 17, 2022 06:47
tzemanovic added a commit that referenced this pull request Aug 17, 2022
* james/misc/gitgnore-anoma:
  Add changelog
  .gitignore: make some patterns relative to repo root
@tzemanovic tzemanovic merged commit a91bd88 into main Aug 17, 2022
@james-chf james-chf deleted the james/misc/gitgnore-anoma branch August 22, 2022 15:10
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
* Updating docs for building interface on macOS

* Adding one note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants