Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate validator set update vote extensions into PrepareProposal #286

Merged
merged 95 commits into from
Aug 30, 2022
Merged

Integrate validator set update vote extensions into PrepareProposal #286

merged 95 commits into from
Aug 30, 2022

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Aug 8, 2022

Implements the third item of issue #242

@sug0 sug0 mentioned this pull request Aug 8, 2022
Closed
@sug0 sug0 force-pushed the tiago/ethbridge/valset-update-prepare-proposal branch 4 times, most recently from cd11ca2 to 21eb81c Compare August 9, 2022 18:01
@sug0 sug0 force-pushed the tiago/ethbridge/valset-update-prepare-proposal branch from 21eb81c to eb1f7d7 Compare August 10, 2022 09:17
sug0 added 15 commits August 10, 2022 10:35
@sug0
Fix up can_send_validator_set_update()
e2c0154 
We will be signing validator set update vote extensions at the last
block before the end of an epoch. New validators will be responsible
for deciding a protocol tx with the validator set update.
@sug0
Start work on validating valset update vote extensions
55f2490
@sug0
Check valset update vext epoch
765c692
@sug0
Replace pos Epoch with storage Epoch type
9264cfb
@sug0
Misc changes
58b345e
@sug0
Improve log messages of vote extension validation
a69f602
@sug0
Verify signature of validator set update vote extension
f3f845b
@sug0
Clean up inclusion of validator set update in vote extension
8a52ab4
@sug0
Remove todo!() to get rid of compiler warnings
b8573d8
@sug0
Implement verify_vote_extension()
6a8e5e4
@sug0
Small fix
751d113
@sug0
Add a TODO
951bacb
@sug0
Add get_epoch_from_height()
36d728c
@sug0
Refactor get next epoch
c3586dd
@sug0
Sign protocol txs in PrepareProposal
1ec6620
@sug0 sug0 force-pushed the tiago/ethbridge/valset-update-prepare-proposal branch from fc84e85 to 5300561 Compare August 25, 2022 09:14
@sug0 sug0 force-pushed the tiago/ethbridge/valset-update-prepare-proposal branch from 5300561 to e693a21 Compare August 25, 2022 12:04
@sug0 sug0 mentioned this pull request Aug 25, 2022
Merged
@sug0 sug0 requested a review from james-chf August 25, 2022 15:28
@sug0 sug0 marked this pull request as ready for review August 25, 2022 15:29
@sug0
Copy link
Collaborator Author

sug0 commented Aug 25, 2022

pls update wasm

batconjurer
batconjurer approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is so much pain headed my way.

@james-chf james-chf mentioned this pull request Aug 30, 2022
Closed
@sug0 sug0 merged commit 47487ef into eth-bridge-integration Aug 30, 2022
@sug0 sug0 deleted the tiago/ethbridge/valset-update-prepare-proposal branch August 30, 2022 13:40
@james-chf james-chf mentioned this pull request Sep 2, 2022
Closed
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
@mateuszjasiuk
feat: shielded transfers in WebWorker (anoma#283)
5454ac8 
* feat: shielded transfers in WebWorker

* fix: anoma tests

* feat: shielded transfers notifications (anoma#286)

* feat: shielded transfers notifications

* feat: add msgId to the toast description

* feat: update masp

* fix: notifications tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-chf james-chf james-chf approved these changes

@batconjurer batconjurer batconjurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sug0 @batconjurer @james-chf @tzemanovic