Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aleks/wallet atomic #2831

Closed
wants to merge 66 commits into from
Closed

Aleks/wallet atomic #2831

wants to merge 66 commits into from

Conversation

karbyshev
Copy link
Contributor

@karbyshev karbyshev commented Mar 6, 2024

Closes #50

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch 3 times, most recently from 6ceb193 to d285065 Compare March 7, 2024 17:34
@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch from 0c0c902 to 1f3edc7 Compare March 7, 2024 21:52
@karbyshev karbyshev self-assigned this Mar 7, 2024
@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch 4 times, most recently from 015df50 to ca00e08 Compare March 8, 2024 13:09
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 8.59599% with 638 lines in your changes missing coverage. Please review.

Project coverage is 59.28%. Comparing base (97ec5b4) to head (ecf3cf4).
Report is 2676 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/wallet/mod.rs 7.37% 540 Missing ⚠️
crates/apps/src/lib/config/genesis/chain.rs 0.00% 30 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 24 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 21 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 13 Missing ⚠️
crates/apps/src/lib/wallet/mod.rs 0.00% 6 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 0.00% 2 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
- Coverage   59.39%   59.28%   -0.12%     
==========================================
  Files         298      298              
  Lines       92771    92995     +224     
==========================================
+ Hits        55104    55134      +30     
- Misses      37667    37861     +194     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch 3 times, most recently from 874ad48 to 5af993e Compare March 8, 2024 18:15
@Fraccaman Fraccaman mentioned this pull request Apr 15, 2024
@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch from 6acb1ab to 90e0cbf Compare April 22, 2024 16:37
@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch from 90e0cbf to b16a38a Compare April 25, 2024 11:03
@karbyshev karbyshev force-pushed the aleks/wallet-atomic branch from 8cb6eff to 5a110d3 Compare April 25, 2024 12:43
This was referenced May 24, 2024
@brentstone brentstone mentioned this pull request Jun 6, 2024
@brentstone
Copy link
Collaborator

@cwgoes @tzemanovic should this PR be closed now?

@tzemanovic tzemanovic closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atomic wallet writes
3 participants