sdk: add logic about TxSubmitError::LowerBondThanUnbond #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2812 +/- ##
=======================================
Coverage 53.44% 53.44%
=======================================
Files 310 310
Lines 101574 101581 +7
=======================================
+ Hits 54288 54292 +4
- Misses 47286 47289 +3 ☔ View full report in Codecov by Sentry. |
|
@brentstone could you help me to review? thank you very much! |
|
hey @cristiantroy , thx for catching this! You're absolutely right that this logic should be here. I'm going to tweak your PR and get it ready for merge (looks like I have permissions to update it here). Just want to make sure CI passes before we merge into upstream Namada |
This was referenced Apr 5, 2024
Closed
|
@brentstone thank you very much for your review. |
tzemanovic
added a commit
that referenced
this pull request
Apr 8, 2024
* cristiantroy/main: sdk: add logic about TxSubmitError::LowerBondThanUnbond
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2810
Reject and return
TxSubmitError::LowerBondThanUnbondwhen the total bonds of the source is lower than the amount to be unbondedIndicate on which release or other PRs this topic is based on
v0.32.1
Checklist before merging to
draft- [ ] I have added a changelog