Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC token query and fix balance query #2729

Merged
merged 47 commits into from
Apr 12, 2024
Merged

IBC token query and fix balance query #2729

merged 47 commits into from
Apr 12, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Feb 26, 2024

Describe your changes

closes #2809
Add ibc-token query to get a list of IBC tokens

Indicate on which release or other PRs this topic is based on

#2631

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 45.67266% with 1268 lines in your changes are missing coverage. Please review.

Project coverage is 53.88%. Comparing base (cc3edde) to head (76c3849).
Report is 113 commits behind head on main.

Files Patch % Lines
crates/ibc/src/context/nft_transfer_mod.rs 7.67% 361 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 152 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 131 Missing ⚠️
crates/apps/src/lib/client/rpc.rs 0.00% 123 Missing ⚠️
crates/ibc/src/lib.rs 60.71% 99 Missing ⚠️
crates/ibc/src/context/nft_transfer.rs 61.68% 82 Missing ⚠️
crates/core/src/ibc.rs 61.02% 76 Missing ⚠️
crates/apps/src/lib/cli.rs 0.00% 63 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 35 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 20 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #2729     +/-   ##
=========================================
  Coverage   53.88%   53.88%             
=========================================
  Files         308      310      +2     
  Lines      100154   101786   +1632     
=========================================
+ Hits        53967    54849    +882     
- Misses      46187    46937    +750     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 changed the title IBC token query IBC token query and fix balance query Mar 13, 2024
tzemanovic
tzemanovic previously approved these changes Mar 20, 2024
yito88 added a commit that referenced this pull request Mar 20, 2024
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/yuji/ibc-token-query:
  specify token addr to query_tokens
  fix e2e test
  fix balance query
  add changelog
  ibc token query

# Conflicts:
#	crates/apps/src/lib/client/rpc.rs
#	crates/sdk/src/wallet/mod.rs
@tzemanovic tzemanovic merged commit 134be07 into main Apr 12, 2024
15 of 19 checks passed
@tzemanovic tzemanovic deleted the yuji/ibc-token-query branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with showing the balance of a particular token.
2 participants