Crash the ledger if committing a block fails #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Abides by #759 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2657 +/- ##
=======================================
Coverage 53.38% 53.39%
=======================================
Files 302 302
Lines 103398 103394 -4
=======================================
+ Hits 55203 55211 +8
+ Misses 48195 48183 -12 ☔ View full report in Codecov by Sentry. |
|
@sug0 I think this is still a breaking changes, no? We could have some nodes crashing with this PR and some other node not crashing on the same block |
|
in theory yes, but I think no one has ever run into a failing |
yito88
approved these changes
Feb 19, 2024
tzemanovic
approved these changes
Feb 20, 2024
Fraccaman
pushed a commit
that referenced
this pull request
Feb 20, 2024
* origin/tiago/commit-failure: Changelog for #2657 Document fields in `commit` response Bump last processed Eth block before calling `commit_block` Remove mut response from `commit` Crash if committing a block fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rather than allowing CometBFT to keep processing blocks after a storage write has failed in Namada, we crash the ledger to avoid any potential corruption of state.
This PR is eligible for non-breaking draft.
Indicate on which release or other PRs this topic is based on
v0.31.4Checklist before merging to
draft