Prepare PoS VP #2604
Merged
Prepare PoS VP #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/prep-pos-vp
branch
from
0227bf1 to
a9fdbd2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 53.88% 53.87% -0.01%
==========================================
Files 308 308
Lines 100154 100158 +4
==========================================
- Hits 53966 53960 -6
- Misses 46188 46198 +10 ☔ View full report in Codecov by Sentry. |
tzemanovic
added a commit
that referenced
this pull request
Feb 22, 2024
tzemanovic
force-pushed
the
brent/prep-pos-vp
branch
from
e589813 to
cff4db6
Compare
tzemanovic
previously approved these changes
Feb 22, 2024
This was referenced Feb 22, 2024
|
this is actually breaking because the VP may give a different result for changed PoS params via gov |
brentstone
pushed a commit
that referenced
this pull request
Feb 23, 2024
brentstone
force-pushed
the
brent/prep-pos-vp
branch
from
cff4db6 to
2e94c8f
Compare
brentstone
pushed a commit
that referenced
this pull request
Feb 28, 2024
brentstone
force-pushed
the
brent/prep-pos-vp
branch
from
2e94c8f to
99709f7
Compare
brentstone
pushed a commit
that referenced
this pull request
Mar 3, 2024
brentstone
force-pushed
the
brent/prep-pos-vp
branch
from
99709f7 to
a2e5020
Compare
tzemanovic
approved these changes
Mar 7, 2024
brentstone
force-pushed
the
brent/prep-pos-vp
branch
from
a2e5020 to
6a6aea6
Compare
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/prep-pos-vp: changelog: add #2604 clean up pos VP
brentstone
pushed a commit
that referenced
this pull request
Mar 8, 2024
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/prep-pos-vp: changelog: add #2604 clean up pos VP
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/prep-pos-vp: changelog: add #2604 clean up pos VP
brentstone
added a commit
that referenced
this pull request
Mar 8, 2024
* brent/prep-pos-vp: changelog: add #2604 clean up pos VP
brentstone
added a commit
that referenced
this pull request
Mar 9, 2024
* origin/brent/prep-pos-vp: changelog: add #2604 clean up pos VP
brentstone
added a commit
that referenced
this pull request
Mar 18, 2024
* origin/brent/prep-pos-vp: changelog: add #2604 clean up pos VP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2059.
Indicate on which release or other PRs this topic is based on
v0.31.9
Checklist before merging to
draft