Masp conversions doesn't require all tokens be in genesis #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we add a rpc call to list all available tokens? Might be nice to also know if they eligible for masp rewards |
|
sug0
previously approved these changes
Dec 15, 2023
|
unit tests timed out on the first run, so I re-ran them |
|
looks like they're still timing out. hm |
maybe #2277 can help? |
|
test devnet help |
|
@Fraccaman, use the following template to test a devnet:
|
…ards while shielded
Fraccaman
approved these changes
Dec 18, 2023
Fraccaman
pushed a commit
that referenced
this pull request
Dec 27, 2023
* origin/bat/fix/masp-rewards-genesis: [feat]: Added an rpc endpoint to query which tokens can earn MASP rewards while shielded [chore]: Add changelog [fix]: Masp conversions no longer requires all tokens be present in genesis
Closed
Fraccaman
pushed a commit
that referenced
this pull request
Dec 27, 2023
* origin/bat/fix/masp-rewards-genesis: [feat]: Added an rpc endpoint to query which tokens can earn MASP rewards while shielded [chore]: Add changelog [fix]: Masp conversions no longer requires all tokens be present in genesis
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/bat/fix/masp-rewards-genesis: [feat]: Added an rpc endpoint to query which tokens can earn MASP rewards while shielded [chore]: Add changelog [fix]: Masp conversions no longer requires all tokens be present in genesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2283
Describe your changes
Previously, a hardcoded set of tokens were expected to be used in Masp conversions.
If these tokens did not have configs in genesis, this would lead to a panic after the first
epoch change. This PR fixes this to use the tokens found in genesis belonging to the MASP
rewards whitelist instead of hardcoding the tokens.
Indicate on which release or other PRs this topic is based on
v0.28
Checklist before merging to
draft