Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache masp verifying keys #2272

Closed
wants to merge 4 commits into from
Closed

cache masp verifying keys #2272

wants to merge 4 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Dec 13, 2023

Describe your changes

Preload MASP params on start up, derive verifying keys and cache them in-memory (using lazy_static).

Indicate on which release or other PRs this topic is based on

0.28.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic requested a review from grarco December 13, 2023 11:33
@tzemanovic tzemanovic marked this pull request as ready for review December 13, 2023 11:33
@tzemanovic tzemanovic marked this pull request as draft December 13, 2023 12:09
@tzemanovic tzemanovic marked this pull request as ready for review December 13, 2023 12:26
Fraccaman pushed a commit that referenced this pull request Dec 13, 2023
* origin/tomas/cache-masp-keys:
  test/sdk/masp: update params tests
  changelog: #2272
  ledger: preload masp verifying keys on start-up
  cache MASP verifying keys in memory
@Fraccaman Fraccaman mentioned this pull request Dec 13, 2023
Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

brentstone pushed a commit that referenced this pull request Dec 13, 2023
brentstone pushed a commit that referenced this pull request Dec 13, 2023
* origin/tomas/cache-masp-keys:
  test/sdk/masp: update params tests
  changelog: #2272
  ledger: preload masp verifying keys on start-up
  cache MASP verifying keys in memory
@tzemanovic tzemanovic mentioned this pull request Dec 13, 2023
@Fraccaman Fraccaman closed this Dec 14, 2023
tzemanovic added a commit that referenced this pull request Dec 14, 2023
Namada 0.28.1 is a patch release that makes improvements to the MASP, SDK, merkle trees, and chain initialization conditions.

* tag 'v0.28.1':
  Namada 0.28.1
  added changelog
  [feat]: Use a backup lookup for pre-genesis wallet.toml files
  added changelog
  fix: makefile
  changelog: add #2263
  add changelog
  Initialize total minted token balances to zero
  added changelog
  finalize_block: fix removed tx changed storage keys
  fix pruning bp merkle tree
  fix: sdk async
  test/sdk/masp: update params tests
  changelog: #2272
  ledger: preload masp verifying keys on start-up
  cache MASP verifying keys in memory
  ci: install cargo about using cargo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants