Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sdk async #2261

Closed
wants to merge 3 commits into from
Closed

fix: sdk async #2261

wants to merge 3 commits into from

Conversation

Fraccaman
Copy link
Member

Describe your changes

Fix the sdk compiling with async-send feature flag.
Added check on Makefile.

Indicate on which release or other PRs this topic is based on

  • 0.28.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman requested a review from murisi December 11, 2023 10:15
@Fraccaman Fraccaman requested a review from tzemanovic December 11, 2023 12:46
@Fraccaman
Copy link
Member Author

spawn devnet help

@namadabot
Copy link

namadabot bot commented Dec 11, 2023

@Fraccaman, use the following template to spawn a devnet:

Field Value
command spawn devnet
template_name string (mandatory)
retention_period date YYYY-MM-DDT00:00:00Z (mandatory)
epochs_per_year number (default to 60000)
block_time number (default to 10)
total_validators number (default to 3)
faucet enum (on, off). Default on.
indexer enum (on, off). Default off.

@Fraccaman
Copy link
Member Author

test devnet help

@namadabot
Copy link

namadabot bot commented Dec 11, 2023

@Fraccaman, use the following template to test a devnet:

Field Value
command test devnet
scenario string (mandatory)
chain id string (mandatory)

@tzemanovic tzemanovic mentioned this pull request Dec 12, 2023
Closed
Fraccaman pushed a commit that referenced this pull request Dec 13, 2023
Merge branch 'fraccaman+bat/fix-sdk-0.28.0' (#2261)
8efc68b 
* origin/fraccaman+bat/fix-sdk-0.28.0:
  fix: makefile
  added changelog
  fix: sdk async
@Fraccaman
Copy link
Member Author

Field Value
command spawn devnet
template_name 0.28.0
retention_period 2023-12-15T00:00:00Z

Fraccaman pushed a commit that referenced this pull request Dec 13, 2023
Merge branch 'fraccaman+bat/fix-sdk-0.28.0' (#2261)
e74223c 
* origin/fraccaman+bat/fix-sdk-0.28.0:
  fix: makefile
  added changelog
  fix: sdk async
@Fraccaman Fraccaman mentioned this pull request Dec 13, 2023
Closed
brentstone pushed a commit that referenced this pull request Dec 13, 2023
@brentstone
Merge branch 'fraccaman+bat/fix-sdk-0.28.0' (#2261)
d3dd56d 
* origin/fraccaman+bat/fix-sdk-0.28.0:
  fix: makefile
  added changelog
  fix: sdk async
@namadabot
Copy link

namadabot bot commented Dec 13, 2023

test

@Fraccaman Fraccaman closed this Dec 14, 2023
@Chambers-ngl
Copy link

completed?

@jokerare000
Copy link

Db?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

@murisi murisi Awaiting requested review from murisi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fraccaman @Chambers-ngl @jokerare000 @tzemanovic