Refactor PoS crate #2253
Merged
Refactor PoS crate #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent+tomas/pos-crate-refactor
branch
2 times, most recently
from
b888ba1 to
1297b81
Compare
Closed
brentstone
force-pushed
the
brent+tomas/pos-crate-refactor
branch
from
8607922 to
04f6705
Compare
brentstone
force-pushed
the
brent+tomas/pos-crate-refactor
branch
from
3bbad24 to
ccc7f45
Compare
brentstone
added a commit
that referenced
this pull request
Dec 19, 2023
* brent+tomas/pos-crate-refactor: changelog: add #2253 proof_of_stake: re-order and make some fns private proof_of_stake: move mod files with other sub-modules compactify code that modifies validator sets resolve clippy refactor pos/tests refactor pos lib code
brentstone
added a commit
that referenced
this pull request
Dec 19, 2023
* brent+tomas/pos-crate-refactor: changelog: add #2253 proof_of_stake: re-order and make some fns private proof_of_stake: move mod files with other sub-modules compactify code that modifies validator sets resolve clippy refactor pos/tests refactor pos lib code
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/brent+tomas/pos-crate-refactor: changelog: add #2253 proof_of_stake: re-order and make some fns private proof_of_stake: move mod files with other sub-modules compactify code that modifies validator sets resolve clippy refactor pos/tests refactor pos lib code
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The goal is primarily to refactor the crate into smaller files.
Old PR: #1928
TODO ideas
pos_queriesand just use existing PoS storage API? --> Could be more of a hassle for not much gain thoughIndicate on which release or other PRs this topic is based on
v0.28.1
Checklist before merging to
draft