Abstract tendermint_node #2127
Merged
Abstract tendermint_node #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariari
force-pushed
the
mariari/basic-abstraction
branch
from
d0a3e1a to
360a09b
Compare
Closed
tzemanovic
reviewed
Dec 12, 2023
tzemanovic
reviewed
Dec 12, 2023
tzemanovic
previously approved these changes
Dec 12, 2023
Before the code would bind a variable just for creating a path, we abstract this out with some functions Further I started to remove the rather verbose file creation
This was an unused function that simply repeated the logic of the non async version
Instead of expecting right away and placing a literal string, we can instead abstract the commonalities of the strings into the error type This shows off a lot of similarities between write_* functions, that can now be cleanly abstracted
After the previous commits the write_validator_state and write_validator_key were basically the same modulo some error parameters and minor state details
Before the function had 3 phases, that was jumbled into 1 whole. There was: 1. setup 2. running 3. response handling Since this structure is rather well defined, and not much data is shared between these phases, we just turn the function into dispatching into functions that reprsent each stage
tzemanovic
force-pushed
the
mariari/basic-abstraction
branch
from
d420ea3 to
4f3bb08
Compare
tzemanovic
approved these changes
Dec 22, 2023
brentstone
added a commit
that referenced
this pull request
Dec 26, 2023
* mariari/basic-abstraction: changelog: add #2127 Abstract `tendermint_node::run` into 3 distinct phases Abstract out the commanality in write tendermint Abstract out file error messages with the error type Remove write_validator repace manua path with functions. Start abstraction on file creation
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
* origin/mariari/basic-abstraction: changelog: add #2127 Abstract `tendermint_node::run` into 3 distinct phases Abstract out the commanality in write tendermint Abstract out file error messages with the error type Remove write_validator repace manua path with functions. Start abstraction on file creation
brentstone
added a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Cleaning up logic pertaining to writing and reading configuration files.
This code has no outward affects, purely for code quality
Indicate on which release or other PRs this topic is based on
0.28.1
Checklist before merging to
draft