Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoS rewards #1992

Merged
merged 19 commits into from
Nov 11, 2023
Merged

PoS rewards #1992

merged 19 commits into from
Nov 11, 2023

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Oct 17, 2023

Describe your changes

A claim-based rewards system for proof-of-stake. Inflationary rewards do not automatically contribute to voting power, but rather must be claimed/withdrawn.

Closes #1130, closes #1770, closes #2058.

Indicate on which release or other PRs this topic is based on

v0.25.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone force-pushed the brent/pos-rewards branch 4 times, most recently from 77bb377 to 630c372 Compare October 20, 2023 19:58
@anoma anoma deleted a comment from nguyenbaongocbkhn Oct 24, 2023
@tzemanovic tzemanovic marked this pull request as ready for review October 27, 2023 07:35
@brentstone brentstone mentioned this pull request Nov 7, 2023
@grarco grarco mentioned this pull request Nov 7, 2023
@grarco grarco mentioned this pull request Nov 7, 2023
@brentstone brentstone added the PoS label Nov 8, 2023
brentstone added a commit that referenced this pull request Nov 8, 2023
@brentstone brentstone force-pushed the brent/pos-rewards branch 4 times, most recently from a5f1432 to de3e50b Compare November 8, 2023 19:53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look like this is accidentally revived

tzemanovic
tzemanovic previously approved these changes Nov 10, 2023
brentstone added a commit that referenced this pull request Nov 10, 2023
* brent/pos-rewards:
  add test for commissions and fix `bond_amounts_for_rewards`
  fix tests
  update `bond_amounts_for_rewards` and `bond_amount`
  misc lib code improvements
  fix rewards tallying: move from within withdraw -> unbond
  add and update tests
  changelog: add #1992
  updates to enable tx from CLI
  update to 0.25.0 base
  change default `kD` and `kP` params
  playground for testing how inflation changes
  WIP more tests
  benches: add a const for "tx_claim_rewards.wasm"
  test/PoS: add rewards related tests
  add a tx to claim PoS rewards
  PoS: apply inflation after processing slashes
  PoS: refactors to use helper functions
  PoS: allow to claim rewards
  PoS: update rewards products to handle commission correctly
@adrianbrink adrianbrink merged commit 5c590e0 into main Nov 11, 2023
13 of 14 checks passed
@adrianbrink adrianbrink deleted the brent/pos-rewards branch November 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants