Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiago] draft #2 #1912

Closed
wants to merge 111 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
d618365
[feat]: Made sdk and client io generic
batconjurer Jul 21, 2023
3c968bf
[fix]: Fixed intra-doc link typo
batconjurer Jul 21, 2023
3b724a9
[chore]: Merge in main
batconjurer Jul 24, 2023
3e651c9
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
c33d0e0
[chore]: Added IO macros to wallet cli. Renamed to
batconjurer Jul 24, 2023
b80a9bd
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
e35ed2e
[chore]: rebasing on bat/generic-io
batconjurer Jul 24, 2023
23af0b5
Merge branch 'bat/feature/int-tests-io' of github.com:anoma/namada in…
batconjurer Jul 24, 2023
c5a2ce2
changelog: add #1746
tzemanovic Jul 25, 2023
cfb57ab
[feat]: Made io reading methods async
batconjurer Jul 26, 2023
79a953f
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
6aa9ee5
[chore]: rebasing on bat/generic-io
batconjurer Jul 24, 2023
9aad0d8
Merge branch 'bat/feature/int-tests-io' of github.com:anoma/namada in…
batconjurer Jul 26, 2023
c833aa3
[fix]: Fixing downstream async io changes from bat/generic-io
batconjurer Jul 26, 2023
2329c2d
[chore]: Merge in main
batconjurer Jul 27, 2023
12f219f
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
014e4f7
[chore]: rebasing on bat/generic-io
batconjurer Jul 24, 2023
c64fdee
[fix]: Fixing downstream async io changes from bat/generic-io
batconjurer Jul 26, 2023
b235ed3
Merge branch 'bat/feature/int-tests-io' of github.com:anoma/namada in…
batconjurer Jul 27, 2023
36fe43e
[feat]: Changed default io read methods to use tokio's async io tools
batconjurer Jul 27, 2023
f046728
[feat]: Changed default io read methods to use tokio's async io tools
batconjurer Jul 27, 2023
c249df8
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
a2c5ced
[chore]: rebasing on bat/generic-io
batconjurer Jul 24, 2023
88820fd
[fix]: Fixing downstream async io changes from bat/generic-io
batconjurer Jul 26, 2023
823fff0
Merge branch 'bat/feature/int-tests-io' of github.com:anoma/namada in…
batconjurer Jul 28, 2023
844e4a2
[feat]: After rebasing on bat/generic-io, need to make io read method…
batconjurer Jul 28, 2023
b734c65
[chore]: Formatting
batconjurer Jul 28, 2023
c855632
[fix]: Removed unused file
batconjurer Aug 15, 2023
078cea0
[chore]: Merge in 0.21.1
batconjurer Sep 1, 2023
bf599b4
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
7198560
[chore]: rebasing on bat/generic-io
batconjurer Jul 24, 2023
46fe66b
[fix]: Fixing downstream async io changes from bat/generic-io
batconjurer Jul 26, 2023
9208268
[feat]: After rebasing on bat/generic-io, need to make io read method…
batconjurer Jul 28, 2023
b6e925f
[chore]: Formatting
batconjurer Jul 28, 2023
9d06bbd
[chore]: merge in v0.21.1
batconjurer Sep 1, 2023
d504e8a
Merge branch 'bat/feature/int-tests-io' of github.com:anoma/namada in…
batconjurer Sep 1, 2023
3df9574
Create the SDK folder and move RPC to it
mariari Sep 6, 2023
539b2c0
Move tx.rs to the SDK crate
mariari Sep 6, 2023
c0f2a62
empty commit
Fraccaman Sep 7, 2023
8925ced
Make `get_total_consensus_stake` public
sug0 Aug 31, 2023
17cb490
Write `PosQueries::get_total_voting_power` based on `get_total_consen…
sug0 Aug 31, 2023
32bac23
Add eth testing util to append validators to storage
sug0 Aug 31, 2023
b5f4caf
Append validators to storage using new testing util
sug0 Aug 31, 2023
f42f6dd
Convert Uint to Amount with 0 denom
sug0 Sep 1, 2023
62184e7
Multiply Amount with FractionalVotingPower
sug0 Sep 1, 2023
9bb7808
Removes redundant `WasmPayload` enum
grarco Sep 7, 2023
651d30f
changelog: add #1874
grarco Sep 7, 2023
561c49a
Rework voting across epochs on Ethereum tallies
sug0 Sep 1, 2023
dcf1dec
Move singing.rs over to the SDK folder
mariari Sep 6, 2023
96918e6
Move masp.rs over to the SDK crate
mariari Sep 6, 2023
78fb259
Move args.rs into the sdk folder
mariari Sep 6, 2023
302dbd4
Move the Client code into the queries module
mariari Sep 6, 2023
22cb300
Move wallet to the SDK
mariari Sep 6, 2023
093a505
Update CONTRIBUTING.md to properly outline how to document SDK changes
mariari Sep 7, 2023
9b8e9cc
Add Changelog explaining the changelog changes
mariari Sep 7, 2023
6b72c72
Shared function to retrieve fee unshielding transaction
grarco Sep 7, 2023
0ba4d78
Refactors masp section check in encryption
grarco Sep 7, 2023
78a23f4
changelog: add #1877
grarco Sep 7, 2023
1c53a58
Move namada::types::error into namada::sdk::error
mariari Sep 8, 2023
fbbdedb
Create Changelog
mariari Sep 7, 2023
2e8975a
Merge branches 'mariari/sdk-folder' and 'mariari/document-sdk-changes…
mariari Sep 8, 2023
0e52848
Changes `SocketAddr` to `String` to identify validators by hostnames
grarco Sep 11, 2023
a57bd89
Refactors `get_actor_rpc`
grarco Sep 12, 2023
891a88c
Adjusts fixme comment on hostname resolution
grarco Sep 12, 2023
1dd35cf
Clippy + fmt
grarco Sep 12, 2023
07a3dac
changelog: add #1886
grarco Sep 12, 2023
79888c8
Merge branch 'base' into bat/generic-io
batconjurer Sep 13, 2023
bdfaff4
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
bbfb810
[fix]: Fixing downstream async io changes from bat/generic-io
batconjurer Jul 26, 2023
4cdcd6c
[feat]: After rebasing on bat/generic-io, need to make io read method…
batconjurer Jul 28, 2023
5244631
[chore]: Formatting
batconjurer Jul 28, 2023
e9a613a
[chore]: merge in v0.21.1
batconjurer Sep 1, 2023
2e31a7d
[feat]: Refactored the masp integration tests to no longer need the n…
batconjurer Jul 24, 2023
17358c3
[chore] Merging in v0.22
batconjurer Sep 13, 2023
eb015c4
Merge branch 'bat/feature/int-tests-io' of github.com:anoma/namada in…
batconjurer Sep 13, 2023
cab0561
Validate txs moving 0 value to the Bridge pool
sug0 Sep 13, 2023
ce407a8
Refactor validate_changed_keys in the Bridge pool VP
sug0 Sep 14, 2023
a524dfa
Changelog for #1892
sug0 Sep 13, 2023
ac727b9
Allow public key to be specified in signature section.
murisi Sep 11, 2023
5946a35
Combining Signature and MultiSignature sections to deduplicate hardwa…
murisi Sep 12, 2023
ab7980b
Added support for compressed signatures coming from hardware wallets.
murisi Sep 13, 2023
6eff4a9
Added changelog entry.
murisi Sep 13, 2023
ac36566
Merge branch 'bat/genesis-io' (#1746)
batconjurer Sep 18, 2023
6c21b08
Evil commit: resolving conflicts with the new sdk sub-directory
batconjurer Sep 18, 2023
a1d4cd8
Merge branch 'bat/feature/int-tests-io' (#1771)
batconjurer Sep 18, 2023
c7c6b93
Remove explicit unreachable match arm
sug0 Sep 18, 2023
8049d74
Changelog for #1865
sug0 Sep 5, 2023
5905e0b
Implement queue of expired txs
sug0 Sep 18, 2023
1116abd
Add expired txs queue to storage
sug0 Sep 18, 2023
c56de22
Refactor broadcasting protocol txs
sug0 Sep 18, 2023
e04b25a
Factor out signing eth events vote extensions in the shell
sug0 Sep 18, 2023
82b97ad
Broadcast expired txs
sug0 Sep 18, 2023
44854c1
Return deleted tally payload if its voting power is >1/3
sug0 Sep 18, 2023
560beea
Add deleted eth events with >1/3 voting power to expired queue
sug0 Sep 18, 2023
8912290
Evil commit: Fixed generic input conflict
batconjurer Sep 18, 2023
705351f
Add test_delete_expired_tally() unit test
sug0 Sep 18, 2023
de1d926
Evil commit: Formatting
batconjurer Sep 18, 2023
58f6992
Add test_commit_broadcasts_expired_eth_events() unit test
sug0 Sep 18, 2023
e3516d7
Evil commit: Fixed removing tokio dep from wasm targeted builds
batconjurer Sep 19, 2023
feae687
ledger: remove faucet, remove pow-for-fee
Fraccaman Sep 6, 2023
d38a6ba
Merge branch 'fraccaman/remove-pow' (#1873)
Fraccaman Sep 20, 2023
46ac295
Merge branch 'murisi/multisig-fixes' (#1884)
murisi Sep 20, 2023
3b5a126
Check if eth events to retransmit are empty
sug0 Sep 21, 2023
2674536
Change wording on Ethereum tally docstr
sug0 Sep 21, 2023
be4985a
Changelog for #1899
sug0 Sep 18, 2023
63dc84b
Merge branch 'grarco/remove-redundant-struct' (#1874)
grarco Sep 21, 2023
b0147b9
Merge branch 'grarco/refactor-get-fee-unshield' (#1877)
grarco Sep 21, 2023
a2213d8
Merge branch 'grarco/validators-by-hostnames' (#1886)
grarco Sep 21, 2023
fdcea56
Merge branch 'tiago/eth-voting-power' (#1865)
sug0 Sep 21, 2023
48185a5
Merge branch 'tiago/retransmit-expired-eth-events' (#1899)
sug0 Sep 21, 2023
f57c975
Merge branch 'tiago/bridge-pool-zero-fees' (#1892)
sug0 Sep 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .changelog/unreleased/SDK/1868-shared-utils-folder.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
- The shared-utils topic ([#1868](https://github.com/anoma/namada/pull/1868)) moves the following:
+ _Modules_
| From | To |
|-----------------------------------------|--------------------------------------|
| namada::ledger::tx | namada::sdk::tx |
| namada::ledger::rpc | namada::sdk::rpc |
| namada::ledger::signing | namada::sdk::signing |
| namada::ledger::masp | namada::sdk::masp |
| namada::ledger::args | namada::sdk::args |
| namada::ledger::wallet::alias | namada::sdk::wallet::alias |
| namada::ledger::wallet::derivation_path | namada::sdk::wallet::derivation_path |
| namada::ledger::wallet::keys | namada::sdk::wallet::keys |
| namada::ledger::wallet::pre_genesis | namada::sdk::wallet::pre_genesis |
| namada::ledger::wallet::store | namada::sdk::wallet::store |
| namada::types::error | namada::sdk::error |

+ _Types_

| From | To |
|---------------------------------|------------------------------|
| namada::ledger::queires::Client | namada::sdk::queires::Client |
2 changes: 2 additions & 0 deletions .changelog/unreleased/features/1746-generic-io.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Replaced standard IO in SDK and client code with a trait that allows custom
handling. ([\#1746](https://github.com/anoma/namada/pull/1746))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/1865-eth-voting-power.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Rework voting on Ethereum tallies across epoch boundaries
([\#1865](https://github.com/anoma/namada/pull/1865))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Move all functions considered to be apart of the SDK to the SDK
folder. ([#1868](https://github.com/anoma/namada/pull/1868))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Removed redundant `WasmPayload` enum in favor of `Commitment`.
([\#1874](https://github.com/anoma/namada/pull/1874))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Added a section in CONTRIBUTING.md to outline how to document SDK
changes ([#1876](https://github.com/anoma/namada/pull/1876))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Refactored retrieval of `Transaction` object for fee unshielding.
([\#1877](https://github.com/anoma/namada/pull/1877))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/1884-multisig-fixes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Enable hardware wallets to participate in nondegenerate multisignature
transactions. ([\#1884](https://github.com/anoma/namada/pull/1884))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Added support for validators' hostnames in configuration.
([\#1886](https://github.com/anoma/namada/pull/1886))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Allow Bridge pool transfers to pay zero gas fees
([\#1892](https://github.com/anoma/namada/pull/1892))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Retransmit timed out Ethereum events in case they have accumulated >1/3 voting
power ([\#1899](https://github.com/anoma/namada/pull/1899))
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The section should either be one of the following choices:
- `features`
- `improvements`
- `testing`
- `SDK`

To add a change log entry using `unclog`, you can fill in the following command (prefer to use the issue number, for which the `--pull-request` argument may be omitted):

Expand All @@ -47,6 +48,13 @@ If none of the sections fit, new sections may be added. To find the existing sec
for i in $(ls -d .changelog/*/*/); do basename "$i"; done | sort | uniq
```

#### SDK Changelog

The Namada SDK is exposed to any developer building upon Namada. Thus, any change made to a public facing function is a breaking change, and therefore should be documented in the Changelog under the `SDK` section.

The message should outline the exact API change, along with a small section describing *how* and *why* the componenet was change. This should give motivation and context to any developer building upon Namada on how they can update their code to the next version.

## Development priorities


If you’d like to follow the development or contribute with new or unimplemented features, we recommend to check [the issues](https://github.com/anoma/namada/issues) that are in current focus of the ledger team.
10 changes: 5 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading