Validate txs moving 0 value to the Bridge pool #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
added
enhancement
batconjurer
requested changes
Sep 14, 2023
sug0
force-pushed
the
tiago/bridge-pool-zero-fees
branch
from
196d10c to
b65e437
Compare
sug0
force-pushed
the
tiago/bridge-pool-zero-fees
branch
from
b65e437 to
a524dfa
Compare
batconjurer
approved these changes
Sep 15, 2023
Closed
tzemanovic
approved these changes
Sep 18, 2023
sug0
added a commit
that referenced
this pull request
Sep 21, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tiago/bridge-pool-zero-fees: Changelog for #1892 Refactor validate_changed_keys in the Bridge pool VP Validate txs moving 0 value to the Bridge pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This patch makes the ledger validate Bridge pool transfers that move no value (either gas fees, or token amounts). This is not necessarily an incorrect behavior per se, albeit an unlikely one, with honest actors in the system. Might be useful to some people, though.
Indicate on which release or other PRs this topic is based on
v0.22.0Checklist before merging to
draft