-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-built MASP proofs for integration tests #1768
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/pregen-masp-proofs
branch
from
July 26, 2023 16:36
29e5b07
to
f805edb
Compare
tzemanovic
force-pushed
the
tomas/pregen-masp-proofs
branch
from
July 27, 2023 07:09
f805edb
to
83f5c2d
Compare
this is awesome! Minor thing: can we remove the masp test from the |
cheers! It is already removed on main but this branch is based on 0.20 so it still appears here |
Fraccaman
added a commit
that referenced
this pull request
Aug 11, 2023
* origin/tomas/pregen-masp-proofs: changelog: add #1768 make: add recipes for integration tests with saved MASP proofs test: add masp_proofs test fixtures shared/masp: allow to save and load proofs for tests
Closed
Fraccaman
added a commit
that referenced
this pull request
Aug 13, 2023
* origin/tomas/pregen-masp-proofs: changelog: add #1768 make: add recipes for integration tests with saved MASP proofs test: add masp_proofs test fixtures shared/masp: allow to save and load proofs for tests
Fraccaman
added a commit
that referenced
this pull request
Aug 13, 2023
* origin/tomas/pregen-masp-proofs: changelog: add #1768 make: add recipes for integration tests with saved MASP proofs test: add masp_proofs test fixtures shared/masp: allow to save and load proofs for tests
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
To speed-up MASP integration tests that were timing out in CI, this PR adds the ability to save and load proofs to/from files stored in
test_fixtures/masp_proofs
.The prebuilt proofs are added to
make test-coverage
to allow running integration tests in the CI.The MASP proof builder in
fn gen_shielded_transfer
is optionally given a seed to produce deterministic output. When not specified, the original behavior is preserved (i.e. usingOsRng
, but now wrapped in StdRng which is cryptographically secure - see https://rust-random.github.io/rand/rand/trait.SeedableRng.html#method.from_rng for more details).To enable deterministic builders, the
Conversions
type and notes positions inShieldedContext
are changed toBTreeMap
andBTreeSet
resp to provide deterministic output fromfn collect_unspent_notes
.Indicate on which release or other PRs this topic is based on
0.20.0
Checklist before merging to
draft