Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoS: purge validator sets for old epochs #1665

Merged
merged 6 commits into from
Jul 22, 2023
Merged

PoS: purge validator sets for old epochs #1665

merged 6 commits into from
Jul 22, 2023

Conversation

karbyshev
Copy link
Contributor

@karbyshev karbyshev commented Jul 5, 2023 •
edited
Loading

Closes #1129

@karbyshev karbyshev self-assigned this Jul 5, 2023
@karbyshev karbyshev changed the title Purge validator sets for old epochs WIP: Purge validator sets for old epochs Jul 5, 2023
@karbyshev karbyshev force-pushed the aleks/clear-out-validator-sets-for-old-epochs branch 4 times, most recently from 89ba523 to aa8da81 Compare July 6, 2023 20:48
@karbyshev karbyshev changed the title WIP: Purge validator sets for old epochs WIP: purge validator sets for old epochs Jul 6, 2023
@karbyshev karbyshev force-pushed the aleks/clear-out-validator-sets-for-old-epochs branch from aa8da81 to c67a7d3 Compare July 7, 2023 11:31
@karbyshev karbyshev changed the title WIP: purge validator sets for old epochs Purge validator sets for old epochs Jul 9, 2023
@karbyshev karbyshev changed the title Purge validator sets for old epochs PoS: purge validator sets for old epochs Jul 10, 2023
tzemanovic
tzemanovic previously approved these changes Jul 10, 2023
View reviewed changes
@karbyshev karbyshev force-pushed the aleks/clear-out-validator-sets-for-old-epochs branch from a06ba10 to 4fc8cf9 Compare July 10, 2023 14:14
tzemanovic
tzemanovic previously approved these changes Jul 10, 2023
View reviewed changes
brentstone
brentstone previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@karbyshev karbyshev dismissed stale reviews from brentstone and tzemanovic via 4abcc9b July 10, 2023 18:23
@karbyshev karbyshev force-pushed the aleks/clear-out-validator-sets-for-old-epochs branch from 6085083 to 4abcc9b Compare July 10, 2023 18:23
@karbyshev
Copy link
Contributor Author

pls update wasm

@tzemanovic tzemanovic mentioned this pull request Jul 11, 2023
Merged
tzemanovic added a commit that referenced this pull request Jul 11, 2023
@tzemanovic
Merge branch 'origin/aleks/clear-out-validator-sets-for-old-epochs' (#…
25e1c0d 
…1665)

* origin/aleks/clear-out-validator-sets-for-old-epochs:
  refactor: fix formatting
  add changelog
  refactor: simplify code
  refactor: introduce name for magic constant
  add test case
  feat: store total consensus stake; garbage collect validator sets
@tzemanovic tzemanovic mentioned this pull request Jul 11, 2023
Closed
@tzemanovic tzemanovic mentioned this pull request Jul 19, 2023
Closed
@Fraccaman Fraccaman mentioned this pull request Jul 20, 2023
Closed
@Fraccaman Fraccaman merged commit d8036f1 into main Jul 22, 2023
9 of 12 checks passed
@Fraccaman Fraccaman deleted the aleks/clear-out-validator-sets-for-old-epochs branch July 22, 2023 11:41
@brentstone brentstone mentioned this pull request Aug 9, 2023
Closed
@sug0 sug0 mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

@brentstone brentstone Awaiting requested review from brentstone

Assignees

@karbyshev karbyshev

Labels
ledger PoS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PoS: clear out validator sets for old epochs
4 participants
@karbyshev @tzemanovic @brentstone @Fraccaman