Murisi/move init proposal content #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Moved init-proposal content into extra data.
…MASP source and target in test vector expert view.
murisi
force-pushed
the
murisi/move-init-proposal-content
branch
from
3c409c4 to
7eef159
Compare
brentstone
reviewed
Jun 26, 2023
Fraccaman
previously approved these changes
Jun 28, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Jul 3, 2023
* origin/murisi/move-init-proposal-content: Added changelog entry. [fix]: Fixed processing of code inside init-proposal transactions. Adjusted expected gas usage in proposal test. Added CLI subcommand for validator change commission. Cleared up the MASP source and target in test vector expert view. Now moving proposal code into extra section. Increased the number of init-proposal and vote-proposal test vectors. Moved init-proposal content into extra data.
murisi
force-pushed
the
murisi/move-init-proposal-content
branch
from
fd75efd to
cbaf707
Compare
This was referenced Jul 4, 2023
Closed
Closed
Closed
Closed
Closed
brentstone
added a commit
that referenced
this pull request
Jul 5, 2023
* murisi/move-init-proposal-content: Added changelog entry. Fixed processing of code inside init-proposal transactions. Added CLI subcommand for validator change commission. Cleared up the MASP source and target in test vector expert view. Now moving proposal code into extra section. Increased the number of init-proposal and vote-proposal test vectors. Moved init-proposal content into extra data.
Fraccaman
added a commit
that referenced
this pull request
Jul 6, 2023
* origin/murisi/move-init-proposal-content: Added changelog entry. Fixed processing of code inside init-proposal transactions. Added CLI subcommand for validator change commission. Cleared up the MASP source and target in test vector expert view. Now moving proposal code into extra section. Increased the number of init-proposal and vote-proposal test vectors. Moved init-proposal content into extra data.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the variety of test vectors in order to facilitate the implementation of hardware wallets. Also some minor modifications to certain transaction encodings to enable processing on hardware constrained wallet devices. More specifically:
contentand part of thetypefield ofInitProposalDataout intoExtraDatasections so that hardware wallets do not have to process these sections.CommissionChangetransactionsChangeCommissiontransactions, and also increased the variety ofInitProposalDataandVoteProposalDatatransactions