storage: add optional prefix iterator methods #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subspace key iterators are created with the iter_prefix() method on the
storage trait, which takes a string as a key prefix. Because the empty
string should be an invalid key for parsing purposes, other topics have
changed key parsing to error on the empty string. However, this leaves
us without a way to iterate over all subspace keys, previously achieved
with iter_prefix("").
To remedy this, iter_prefix has been extended into
iter_optional_prefix, taking an optional Key. Calls to iter_prefix("")
can be replaced with iter_all(), a new method; iter_prefix() still
exists with its original signature but will no longer accept empty
strings.
tzemanovic
approved these changes
May 26, 2023
Fraccaman
added a commit
that referenced
this pull request
Jun 9, 2023
* origin/ray/iter-optional-prefix: storage: add optional prefix iterator methods
Closed
Fraccaman
added a commit
that referenced
this pull request
Jun 14, 2023
* origin/ray/iter-optional-prefix: storage: add optional prefix iterator methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subspace key iterators are created with the iter_prefix() method on the
storage trait, which takes a string as a key prefix. Because the empty
string should be an invalid key for parsing purposes, other topics have
changed key parsing to error on the empty string. However, this leaves
us without a way to iterate over all subspace keys, previously achieved
with iter_prefix("").
To remedy this, iter_prefix has been extended into
iter_optional_prefix, taking an optional Key. Calls to iter_prefix("")
can be replaced with iter_all(), a new method; iter_prefix() still
exists with its original signature but will no longer accept empty
strings.