apps/config: remove DEFAULT_BASE_DIR constant #1367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
juped
force-pushed
the
ray/base-directory-no-constant
branch
from
8b5ef3f
to
b9c5711
Compare
Now that Namada defaults to platform-compliant (e.g. XDG) default data
directories, the DEFAULT_BASE_DIR constant (".namada") should no longer
exist. Remove it, using get_default_namada_folder() in places which
referenced it.
The ultimate fallback in case get_default_namada_folder() fails remains
".namada", but this is now just a string inside
get_default_namada_folder(). This will not happen except in
pathological cases where e.g. no $HOME exists; the details are in the
documentation for the directories crate.
juped
force-pushed
the
ray/base-directory-no-constant
branch
from
b9c5711
to
56efbf4
Compare
tzemanovic
reviewed
May 15, 2023
| @@ -420,7 +421,7 @@ impl Test { | |||
| .join(self.net.chain_id.as_str()) | |||
| .join(utils::NET_ACCOUNTS_DIR) | |||
| .join(format!("validator-{}", index)) | |||
| .join(config::DEFAULT_BASE_DIR), | |||
| .join(default_namada_folder), | |||
There was a problem hiding this comment.
This won't work as default_namada_folder is an absolute path and so with .join it overrides the path in full. We could probably keep using .namada for e2e tests, or perhaps better just use the "validator-{}" as a base dir
There was a problem hiding this comment.
a lot of this won't work, i just can't proceed with this yet
|
should we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Namada defaults to platform-compliant (e.g. XDG) default data
directories, the DEFAULT_BASE_DIR constant (".namada") should no longer
exist. Remove it, using get_default_namada_folder() in places which
referenced it.
The ultimate fallback in case get_default_namada_folder() fails remains
".namada", but this is now just a string inside
get_default_namada_folder(). This will not happen except in
pathological cases where e.g. no $HOME exists; the details are in the
documentation for the directories crate.