Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the base dir where i could find it #1364

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

bengtlofgren
Copy link
Contributor

No description provided.

@bengtlofgren bengtlofgren marked this pull request as ready for review May 12, 2023 22:41
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengtlofgren bengtlofgren merged commit 8e830ef into main May 12, 2023
@bengtlofgren bengtlofgren deleted the bengt/base-dir-docs branch May 12, 2023 23:36
@juped
Copy link
Member

juped commented May 13, 2023

This allergy to mentioning $XDG_DATA_HOME is going to be extremely confusing.

This is also wrong; the data directory should not be in $XDG_CONFIG_HOME but in $XDG_DATA_HOME, and indeed #1138 gets data directories, not config directories. I checked to be sure and it does indeed put it in a data directory (i.e., ~/.local/share/namada because I have no $XDG_DATA_HOME set).

Disapproved for the above reasons, should not have been merged; not going to revert because that would be going to a different wrong state.

(We need to get the docs out of this repository ASAP)

@juped juped restored the bengt/base-dir-docs branch May 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants