Remove wasm code from tx #1297
Merged
Remove wasm code from tx #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls update wasm |
|
pls update wasm |
juped
added a commit
that referenced
this pull request
Apr 16, 2023
…nt-0.15 * namada/yuji/wasm_hash: add changelog fix vp wasm tests fix vp_implicit test for CI [ci] wasm checksums update fix wasm cache file path fix e2e test: invalid_transactions fix vp whitelist checking [ci] wasm checksums update for client for vp handling modify wasm cache
Merged
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
reviewed
Apr 17, 2023
tzemanovic
previously approved these changes
Apr 17, 2023
juped
reviewed
Apr 17, 2023
apps/src/lib/config/genesis.rs
Outdated
There was a problem hiding this comment.
why are the genesis hashes removed here? they are not directly related to the whitelist; they are an integrity check on the genesis bundle, so we die on genesis if the wrong wasms are present
There was a problem hiding this comment.
I thought the genesis hashes should be exactly the same as the hashes on the whitelists. Do you mean that we shouldn't die on genesis even if they mismatch?
There was a problem hiding this comment.
ah, if whitelists are empty, we need to check hashes with them. I will revert the hash members and add the hash checking.
|
pls update wasm |
juped
added a commit
that referenced
this pull request
Apr 17, 2023
…nt-0.15 * namada/yuji/wasm_hash: add changelog fix vp wasm tests fix vp_implicit test for CI [ci] wasm checksums update fix wasm cache file path fix e2e test: invalid_transactions fix vp whitelist checking [ci] wasm checksums update for client for vp handling modify wasm cache
tzemanovic
approved these changes
Apr 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tx/vp wasm code from a transaction
A transaction has the hash instead of the actual wasm code.
Each node stores wasms in the storage and fetches them according to hashes included in requested transactions.