SDK changes to help the interface #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
force-pushed
the
mateusz/shared-sdk-integration-wip
branch
from
0a1d08f
to
8c0bb97
Compare
|
What changes does this make, and do we still need them? If so, can you rebase on @juped's SDK branch? |
So these changes are needed for shielded transfers to work. I would rather add them after Ray merges Sdk branch to main. The reasons are:
I think the best approach would be for Ray to finish the merge, then change masp_primitives and masp_proofs(I think change there is only with feature flags, but need to double check), and then merge those changes. |
10 tasks
mateuszjasiuk
force-pushed
the
mateusz/shared-sdk-integration-wip
branch
2 times, most recently
from
844c58d
to
8da0c27
Compare
cwgoes
force-pushed
the
mateusz/shared-sdk-integration-wip
branch
from
1ba2335
to
e72eb4c
Compare
cwgoes
added a commit
that referenced
this pull request
May 19, 2023
* mateusz/shared-sdk-integration-wip: feat: point to the masp_proofs with correct multicore feature flag feat: disable multicore ff by default, make ShieldedUtils trait async
Closed
tzemanovic
force-pushed
the
mateusz/shared-sdk-integration-wip
branch
from
e72eb4c
to
ec64402
Compare
tzemanovic
approved these changes
May 21, 2023
tzemanovic
added a commit
that referenced
this pull request
May 21, 2023
* mateusz/shared-sdk-integration-wip: changelog: add #1238 wasm: update checksums feat: point to the masp_proofs with correct multicore feature flag feat: disable multicore ff by default, make ShieldedUtils trait async format: rustfmt for incorrect sdk-wallet-force commits changelog: add #925, update changelog: add #889 DoS checks in fee specs for fee unshielding ci: remove clippy-abcipp check Adjusts block proposer address in fee specs Improves unshielding tx verification in fee specs Updates tendermint link in fee specs Improves gas accounting in specs Updates check table in fee specs Misc updates to fee specs Fixes wal in fee specs Adds protocol transactions to fee specs Adds governance proposals to fee specs Fixes unshielding in fee specs Enforces tx type order in fee specs Refactors sections of fee specs Adds unshielding to fee specs Updates fee specs Adds fee specs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
multicorefeature flag to thesharedandcore.Changed
ShieldedUtilstrait to be async.Before merging this, it would be nice to change
masp_proofs, to be able to turn off themulticoreinlibrustzcash.Something like this:
With those changes shielded transfers should work in browser.