Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/alternative txs #1156

Closed
wants to merge 10 commits into from
Closed

Murisi/alternative txs #1156

wants to merge 10 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Feb 14, 2023

The objective is to (with as little change as possible) make Namada transactions signable on hardware constrained wallets by making them smaller. The approach to this taken in this branch is to replace inner transactions (amongst other objects) with their hashes, and then only attach the encrypted payloads at the top level.

More precisely, the following changes have been made:

  • Removed the inner_tx field of WrapperTx leaving behind tx_hash
  • Added an inner_tx field to Tx representing an attached encrypted inner transaction
  • The ledger now decrypts and checks the attached inner_tx field against the Wrapper::tx_hash field

The implications of these changes are:

  • No encryption is required for/before the signing process (and hence on hardware wallets) because the signature for a WrapperTx is over the hash of an unencrypted Tx

@murisi
Copy link
Contributor Author

murisi commented Feb 14, 2023

pls update wasm

@murisi
Copy link
Contributor Author

murisi commented Feb 14, 2023

pls restart ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant